You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/08/02 12:47:45 UTC
[GitHub] flink pull request #4463: [FLINK-7335] [futures] Remove Flink's own Future i...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4463
[FLINK-7335] [futures] Remove Flink's own Future implementation
## What is the purpose of the change
Remove Flink's own Future implementation in favour of Java 8's `CompletableFuture`.
This PR is based on #4462.
## Brief change log
- Delete unused interface and class files
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink removeFutures
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4463.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4463
----
commit 0e497367d8666a580d033848977b0639b037e554
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-08-01T09:33:48Z
[FLINK-7334] [futures] Replace Flink's futures with Java 8's CompletableFuture in RpcEndpoint, RpcGateways and RpcService
Remove Futures from RpcGateways
Remove Future usage
commit 2302fbe2e201a8c871521a8f2cc970ffc9dbf0f0
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-08-02T12:40:36Z
[FLINK-7335] [futures] Remove Flink's own Future implementation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4463: [FLINK-7335] [futures] Remove Flink's own Future i...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4463#discussion_r130866931
--- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala ---
@@ -21,7 +21,7 @@ package org.apache.flink.runtime.jobmanager
import java.io.IOException
import java.net._
import java.util.UUID
-import java.util.concurrent.{Future => JavaFuture, _}
+import java.util.concurrent.{TimeUnit, Future => _, TimeoutException => _, _}
--- End diff --
What is `Future => _` doing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4463: [FLINK-7335] [futures] Remove Flink's own Future implemen...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4463
Thanks for the review @zentol. Merging this PR after merging #4462.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4463: [FLINK-7335] [futures] Remove Flink's own Future i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4463
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4463: [FLINK-7335] [futures] Remove Flink's own Future i...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4463#discussion_r131120916
--- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala ---
@@ -21,7 +21,7 @@ package org.apache.flink.runtime.jobmanager
import java.io.IOException
import java.net._
import java.util.UUID
-import java.util.concurrent.{Future => JavaFuture, _}
+import java.util.concurrent.{TimeUnit, Future => _, TimeoutException => _, _}
--- End diff --
Exclude `Future` from being imported.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---