You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/12/15 02:11:53 UTC
[GitHub] [incubator-celeborn] zwangsheng opened a new pull request, #1084: [CELEBORN-143][HELM]Exposing pods details to users
zwangsheng opened a new pull request, #1084:
URL: https://github.com/apache/incubator-celeborn/pull/1084
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Move affinity to `values.yaml`.
### Why are the changes needed?
We should expose the details of the pod for users to view and modify in values.yaml
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
Local test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1084: [HELM]Exposing pods details to users
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #1084:
URL: https://github.com/apache/incubator-celeborn/pull/1084#issuecomment-1352458329
Have you opened JIRA for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1084: [HELM]Exposing pods details to users
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1084:
URL: https://github.com/apache/incubator-celeborn/pull/1084#issuecomment-1350686179
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1084](https://codecov.io/gh/apache/incubator-celeborn/pull/1084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (42eded2) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/17f45453e3e00ecf4062b9b6b6db76a4aeae5c2c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (17f4545) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1084 +/- ##
============================================
- Coverage 25.29% 25.25% -0.05%
+ Complexity 776 772 -4
============================================
Files 212 212
Lines 18032 18037 +5
Branches 2036 2037 +1
============================================
- Hits 4561 4555 -6
- Misses 13165 13172 +7
- Partials 306 310 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `69.26% <0.00%> (-2.46%)` | :arrow_down: |
| [...ice/deploy/master/clustermeta/ha/StateMachine.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvY2x1c3Rlcm1ldGEvaGEvU3RhdGVNYWNoaW5lLmphdmE=) | `60.57% <0.00%> (-1.79%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zwangsheng commented on pull request #1084: [HELM]Exposing pods details to users
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on PR #1084:
URL: https://github.com/apache/incubator-celeborn/pull/1084#issuecomment-1352460004
> Have you opened JIRA for this PR?
I will add a ticket in jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1084: [CELEBORN-143][HELM]Exposing pods details to users
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #1084:
URL: https://github.com/apache/incubator-celeborn/pull/1084#issuecomment-1352466934
Thanks, merging to main/0.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 merged pull request #1084: [CELEBORN-143][HELM]Exposing pods details to users
Posted by GitBox <gi...@apache.org>.
pan3793 merged PR #1084:
URL: https://github.com/apache/incubator-celeborn/pull/1084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1084: [CELEBORN-143][HELM]Exposing pods details to users
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1084: [CELEBORN-143][HELM]Exposing pods details to users
URL: https://github.com/apache/incubator-celeborn/pull/1084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org