You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by ov...@apache.org on 2021/04/06 09:06:35 UTC

[echarts] branch fix-symbol created (now cd523cd)

This is an automated email from the ASF dual-hosted git repository.

ovilia pushed a change to branch fix-symbol
in repository https://gitbox.apache.org/repos/asf/echarts.git.


      at cd523cd  fix(graph): no symbol when offset is not defined

This branch includes the following new commits:

     new cd523cd  fix(graph): no symbol when offset is not defined

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[echarts] 01/01: fix(graph): no symbol when offset is not defined

Posted by ov...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ovilia pushed a commit to branch fix-symbol
in repository https://gitbox.apache.org/repos/asf/echarts.git

commit cd523cd86b8fc7c6de1a5994ca029f4e3aa267dc
Author: Ovilia <zw...@gmail.com>
AuthorDate: Tue Apr 6 17:04:04 2021 +0800

    fix(graph): no symbol when offset is not defined
    
    This may be a bug raised from #14375
---
 src/chart/helper/Line.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/chart/helper/Line.ts b/src/chart/helper/Line.ts
index 1f0a184..b2edb27 100644
--- a/src/chart/helper/Line.ts
+++ b/src/chart/helper/Line.ts
@@ -70,7 +70,7 @@ function createSymbol(name: 'fromSymbol' | 'toSymbol', lineData: LineList, idx:
 
     const symbolSize = lineData.getItemVisual(idx, name + 'Size' as 'fromSymbolSize' | 'toSymbolSize');
     const symbolRotate = lineData.getItemVisual(idx, name + 'Rotate' as 'fromSymbolRotate' | 'toSymbolRotate');
-    const symbolOffset = lineData.getItemVisual(idx, name + 'Offset' as 'fromSymbolOffset' | 'toSymbolOffset');
+    const symbolOffset = lineData.getItemVisual(idx, name + 'Offset' as 'fromSymbolOffset' | 'toSymbolOffset') || 0;
     const symbolKeepAspect = lineData.getItemVisual(idx,
         name + 'KeepAspect' as 'fromSymbolKeepAspect' | 'toSymbolKeepAspect');
 

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org