You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2020/10/07 17:44:53 UTC

[GitHub] [incubator-pagespeed-ngx] Ost11 opened a new issue #1715: Add gtag.js with Insert Google Analytics

Ost11 opened a new issue #1715:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1715


   Is there a possibility to add the new google Global Site Tag (gtag.js) in the filter Insert Google Analytics? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-pagespeed-ngx] oschaaf commented on issue #1715: Add gtag.js with Insert Google Analytics

Posted by GitBox <gi...@apache.org>.

oschaaf commented on issue #1715:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1715#issuecomment-705188297


   that would require a modification to https://github.com/apache/incubator-pagespeed-mod/blob/d8d13e85f8356e361e9faa4091f305202415f0f8/net/instaweb/rewriter/insert_ga_filter.cc plus tests to ensure it works in https://github.com/apache/incubator-pagespeed-mod/blob/2349e76f8a30512cb68d13bbbecc11b03f087d6f/test/net/instaweb/rewriter/insert_ga_filter_test.cc
   
   It certainly seems doable to me, but I don't think anyone is looking into it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org