You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by somideshmukh <gi...@git.apache.org> on 2015/11/07 10:10:01 UTC
[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...
GitHub user somideshmukh opened a pull request:
https://github.com/apache/spark/pull/9537
[SPARK-11551][DOC][Example]Replace example code in ml-features.md using include_example
Replaced Java and Scala code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/somideshmukh/spark NewBranch1.5.1-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9537.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9537
----
commit be53d3006865182e68c2c69eb432188c7009c4fe
Author: somideshmukh <so...@us.ibm.com>
Date: 2015-11-04T11:08:39Z
[SPARK-10946][SQL]JDBC - Use Statement.executeUpdate instead of PreparedStatement.executeUpdate for DDLs
commit bfd43ab10d987e5dc23d008370a8cf7c4a782bd6
Author: somideshmukh <so...@us.ibm.com>
Date: 2015-11-07T08:37:22Z
[SPARK-11551][Example][Doc]Replace example code in ml-features.md using include_example
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...
Posted by yinxusen <gi...@git.apache.org>.
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9537#issuecomment-155026161
@somideshmukh Pls follow [Spark Style Guide](https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide). E.g. All Java code should follow 2-indention style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...
Posted by somideshmukh <gi...@git.apache.org>.
Github user somideshmukh closed the pull request at:
https://github.com/apache/spark/pull/9537
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...
Posted by somideshmukh <gi...@git.apache.org>.
Github user somideshmukh commented on the pull request:
https://github.com/apache/spark/pull/9537#issuecomment-156945905
I am working on this,today it will be completed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...
Posted by yinxusen <gi...@git.apache.org>.
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9537#issuecomment-156469579
@somideshmukh Do you still have time for this? I can help if you don't have enough time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9537#issuecomment-154665282
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...
Posted by yinxusen <gi...@git.apache.org>.
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9537#issuecomment-154937549
@somideshmukh Thanks for working on this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org