You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/02 06:27:12 UTC

[GitHub] [flink] c4emmmm commented on issue #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

c4emmmm commented on issue #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge
URL: https://github.com/apache/flink/pull/8872#issuecomment-507537975
 
 
   > Thanks @c4emmmm .
   > 
   > I think we should also add a `CsvTableSourceITCase` in blink-planner to verify the lookup and scan can work well.
   > 
   > You can refer to `org.apache.flink.table.sources.csv.CsvTableSourceITCase#testTemporalJoinCsv`.
   
   @wuchong Thanks for your feedback. I have push a commit with most points fixed. Test case would be a follow-up commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services