You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/06 13:51:15 UTC

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #6891: GEODE-9627: Add service provider interface to register DataSerializableFixedIDs

jdeppe-pivotal commented on a change in pull request #6891:
URL: https://github.com/apache/geode/pull/6891#discussion_r723297754



##########
File path: geode-core/src/upgradeTest/java/org/apache/geode/ClusterCommunicationsDUnitTest.java
##########
@@ -138,6 +138,15 @@
   @Rule
   public SerializableTestName testName = new SerializableTestName();
 
+  @BeforeClass
+  public static void setup() {
+    DUnitLauncher.launchIfNeeded(NUM_SERVERS + 1);
+    invokeInEveryVM(
+        () -> InternalDataSerializer.getDSFIDSerializer().register(
+            SerialAckedMessageWithBigReply.DSFID,
+            SerialAckedMessageWithBigReply.class));
+  }
+

Review comment:
       Since I've added checks to throw an exception on duplicate fixed Id registration, this can only happen once - hence putting it in a `@BeforeClass`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org