You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Pierre Smits (JIRA)" <ji...@apache.org> on 2015/10/21 10:02:27 UTC

[jira] [Commented] (OFBIZ-6690) replace widget-style="required" with required-field="true"

    [ https://issues.apache.org/jira/browse/OFBIZ-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966403#comment-14966403 ] 

Pierre Smits commented on OFBIZ-6690:
-------------------------------------

Hi Taher,

I counted far less in the patch I provided, but you are right: there are more in other files.

The related aspect in the renderer in htmlFormMacroLibrary is this:
{code}
<#macro renderAsterisks requiredField requiredStyle>
  <#if requiredField=="true"><#if !requiredStyle?has_content>*</#if></#if>
</#macro>
{code}

And yes, I did test. 

> replace widget-style="required" with required-field="true"
> ----------------------------------------------------------
>
>                 Key: OFBIZ-6690
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6690
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>              Labels: validation
>         Attachments: OFBIZ-6690-SetupForms.xml.patch, OFBIZ-6690-removewidgetstyle.patch
>
>
> Currently many fields have 'widget-style="required" to indicate that input for the field is required. Better is it to have 'required-field="true". This not only opens up the possibility to define additional validation rules, but the rendered also incorporates the aspects associated with 'widget-style="required".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)