You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ad...@apache.org on 2014/10/28 16:24:33 UTC
[5/9] git commit: Document magic number in NodeMetadata for Docker
Document magic number in NodeMetadata for Docker
Project: http://git-wip-us.apache.org/repos/asf/jclouds-labs/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/d9f52123
Tree: http://git-wip-us.apache.org/repos/asf/jclouds-labs/tree/d9f52123
Diff: http://git-wip-us.apache.org/repos/asf/jclouds-labs/diff/d9f52123
Branch: refs/heads/1.8.x
Commit: d9f521235b08ec8677ca4e8729928bbacc15885a
Parents: ae3548d
Author: Andrew Kennedy <an...@cloudsoftcorp.com>
Authored: Fri Oct 10 21:19:57 2014 +0100
Committer: Adrian Cole <ad...@apache.org>
Committed: Tue Oct 28 08:19:40 2014 -0700
----------------------------------------------------------------------
.../docker/compute/functions/ContainerToNodeMetadata.java | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/d9f52123/docker/src/main/java/org/jclouds/docker/compute/functions/ContainerToNodeMetadata.java
----------------------------------------------------------------------
diff --git a/docker/src/main/java/org/jclouds/docker/compute/functions/ContainerToNodeMetadata.java b/docker/src/main/java/org/jclouds/docker/compute/functions/ContainerToNodeMetadata.java
index 580e5f1..3ec7f5c 100644
--- a/docker/src/main/java/org/jclouds/docker/compute/functions/ContainerToNodeMetadata.java
+++ b/docker/src/main/java/org/jclouds/docker/compute/functions/ContainerToNodeMetadata.java
@@ -48,6 +48,14 @@ import com.google.inject.Singleton;
@Singleton
public class ContainerToNodeMetadata implements Function<Container, NodeMetadata> {
+ /**
+ * This value is used when a container does not have an accessible
+ * login port (i.e. the SSH daemon is not running) due to being
+ * started outside jclouds. Client code should check for this value
+ * when accessing NodeMetadata from Docker.
+ */
+ public static final Integer NO_LOGIN_PORT = Integer.valueOf(-1);
+
private final ProviderMetadata providerMetadata;
private final Function<State, NodeMetadata.Status> toPortableStatus;
private final GroupNamingConvention nodeNamingConvention;
@@ -125,6 +133,6 @@ public class ContainerToNodeMetadata implements Function<Container, NodeMetadata
}
}
}
- return -1;
+ return NO_LOGIN_PORT;
}
}