You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/04 11:27:01 UTC
[GitHub] [arrow-julia] complyue opened a new pull request #296: Solving #295
complyue opened a new pull request #296:
URL: https://github.com/apache/arrow-julia/pull/296
Please review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] complyue closed pull request #296: Solving #295
Posted by GitBox <gi...@apache.org>.
complyue closed pull request #296:
URL: https://github.com/apache/arrow-julia/pull/296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] quinnj commented on pull request #296: Solving #295
Posted by GitBox <gi...@apache.org>.
quinnj commented on pull request #296:
URL: https://github.com/apache/arrow-julia/pull/296#issuecomment-1059875570
@complyue, thanks for the contribution! I spent some time reviewing your PR and something seemed very familiar about the problem. And that's when I remembered that we already solved this on the `Arrow.write` side, so I think it makes sense to use the same utility type (`OrderedChannel`) on the reading side. See my PR here: https://github.com/apache/arrow-julia/pull/298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] complyue commented on pull request #296: Solving #295
Posted by GitBox <gi...@apache.org>.
complyue commented on pull request #296:
URL: https://github.com/apache/arrow-julia/pull/296#issuecomment-1060298468
@quinnj, thanks for providing your solution, I prefer your PR instead of this one, so closing.
I've also removed changes in this PR from PR #297, so #297 becomes a clean PR on its own, please review that sooner, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] codecov-commenter commented on pull request #296: Solving #295
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #296:
URL: https://github.com/apache/arrow-julia/pull/296#issuecomment-1059541727
# [Codecov](https://codecov.io/gh/apache/arrow-julia/pull/296?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#296](https://codecov.io/gh/apache/arrow-julia/pull/296?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (684d533) into [main](https://codecov.io/gh/apache/arrow-julia/commit/614fce0a5d7db8fee078be32690c5220848538e2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (614fce0) will **decrease** coverage by `0.08%`.
> The diff coverage is `92.30%`.
[](https://codecov.io/gh/apache/arrow-julia/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #296 +/- ##
==========================================
- Coverage 87.00% 86.92% -0.09%
==========================================
Files 26 26
Lines 3263 3257 -6
==========================================
- Hits 2839 2831 -8
- Misses 424 426 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-julia/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/table.jl](https://codecov.io/gh/apache/arrow-julia/pull/296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3RhYmxlLmps) | `95.33% <92.30%> (-0.56%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-julia/pull/296?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-julia/pull/296?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [614fce0...684d533](https://codecov.io/gh/apache/arrow-julia/pull/296?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org