[jira] [Commented] (TAP5-1803) URL encoding in ActivationRequestParameter is very strict

["Rural Hunter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176079#comment-16176079 ] 

Rural Hunter commented on TAP5-1803:
------------------------------------

In our environment, we just did this in ActivationRequestParameterWorker:
change the line "clientValue = urlEncoder.decode(clientValue);" to this:
                try
                {
                    clientValue = urlEncoder.decode(clientValue);
                }
                catch(IllegalArgumentException ie)
                {
                    
                }
if URLEncoderImpl can decode, we let it decode. If it cannot, we do nothing.

> URL encoding in ActivationRequestParameter is very strict
> ---------------------------------------------------------
>
>                 Key: TAP5-1803
>                 URL: https://issues.apache.org/jira/browse/TAP5-1803
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.1, 5.4
>            Reporter: David Canteros
>              Labels: @ActivationRequestParameter, InvalidaArgumenteException, URLEncoder,, desired_for_5.5
>
> The URLEncoder that perform the URL encoding process does not include the following "unreserved characters" : 	 
>  !  ~  *  ' (  )	 
> (see rfc2396 Uniform Resource Identifiers (URI): Generic Syntax, item 2.3)
> 	 
> Because the fix of TAP5-1768, from v5.3.1 the @ActivationRequestParameter requires this enconding, which becomes incompatible with the standard.
> Thus, any URL which contains those symbols will throw an InvalidaArgumenteException. Tapestry should consider that the ActivationRequestParameter is a standar way of parameter sending, and the parameters sent in this way probably not have the "strict" coding process of the URLEncoder.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)