You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/20 09:18:22 UTC

[GitHub] [flink] dixingxing0 opened a new pull request #14706: FLINK-20913:Improve HiveConf creation

dixingxing0 opened a new pull request #14706:
URL: https://github.com/apache/flink/pull/14706


   ## What is the purpose of the change
   
   This pull request improves HiveConf creation. see https://issues.apache.org/jira/browse/FLINK-20913
   
   ## Brief change log
   Introduce HiveConfUtils to create HiveConf instance, avoid reset hive configuration to default value.
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *(HiveTableSourceITCase)*.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature?  no
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong merged pull request #14706: [FLINK-20913][hive]Improve HiveConf creation for release-1.12

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14706:
URL: https://github.com/apache/flink/pull/14706


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14706: [FLINK-20913][hive]Improve HiveConf creation for release-1.12

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14706:
URL: https://github.com/apache/flink/pull/14706#issuecomment-763479494


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a51a06fb6853169f59209afc5f3d696c836b3e72",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a51a06fb6853169f59209afc5f3d696c836b3e72",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a51a06fb6853169f59209afc5f3d696c836b3e72 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14706: [FLINK-20913][hive]Improve HiveConf creation for release-1.12

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14706:
URL: https://github.com/apache/flink/pull/14706#issuecomment-763479494


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a51a06fb6853169f59209afc5f3d696c836b3e72",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12278",
       "triggerID" : "a51a06fb6853169f59209afc5f3d696c836b3e72",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a51a06fb6853169f59209afc5f3d696c836b3e72 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12278) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14706: [FLINK-20913][hive]Improve HiveConf creation for release-1.12

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14706:
URL: https://github.com/apache/flink/pull/14706#issuecomment-763479494


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a51a06fb6853169f59209afc5f3d696c836b3e72",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12278",
       "triggerID" : "a51a06fb6853169f59209afc5f3d696c836b3e72",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a51a06fb6853169f59209afc5f3d696c836b3e72 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12278) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong merged pull request #14706: [FLINK-20913][hive]Improve HiveConf creation for release-1.12

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14706:
URL: https://github.com/apache/flink/pull/14706


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14706: FLINK-20913:Improve HiveConf creation

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14706:
URL: https://github.com/apache/flink/pull/14706#issuecomment-763461618


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit a51a06fb6853169f59209afc5f3d696c836b3e72 (Wed Jan 20 09:21:18 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org