[jira] [Commented] (SOLR-9295) Remove Unicode BOM (U+FEFF) from text files in codebase

["Shawn Heisey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371309#comment-15371309 ] 

Shawn Heisey commented on SOLR-9295:
------------------------------------

I wonder how difficult it would be put a check for BOM into the precommit target, and whether such a thing might be worthwhile.

> Remove Unicode BOM (U+FEFF) from text files in codebase
> -------------------------------------------------------
>
>                 Key: SOLR-9295
>                 URL: https://issues.apache.org/jira/browse/SOLR-9295
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: scripts and tools
>    Affects Versions: master (7.0)
>            Reporter: Shawn Heisey
>            Priority: Trivial
>
> When starting Solr built from the master branch on Windows, this is what you see:
> {noformat}
> C:\Users\elyograg\git\lucene-solr\solr>bin\solr start
> C:\Users\elyograg\git\lucene-solr\solr>@REM
> '@REM' is not recognized as an internal or external command,
> operable program or batch file.
> {noformat}
> The three extra characters, found at the very beginning of the solr.cmd script, are a Unicode BOM, and are invisible to vim, notepad, and notepad++.  
> The problem does not exist in 6.1.0, but IS present in branch_6x and master.
> Using grep to find this character in the entire codebase, I found one other file with a BOM:
> ./solr/webapp/web/js/lib/jquery.blockUI.js



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org