You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/06/26 06:45:17 UTC
Review Request 22999: Use immutable types in AttributeStore.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22999/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Maxim Khutornenko.
Repository: aurora
Description
-------
Prep work for replacing MemAttributeStore with a database-backed store. Immutable types aren't strictly necessary, but it's a good change to make.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/TaskVars.java 75e791709262319a45c1dacd768708e3a2122f67
src/main/java/org/apache/aurora/scheduler/base/Conversions.java 02e57acae30b1b1ea6ef7f041902ab319b5ef88b
src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 1afc6ca036e7f52f81775f029779badfb36e09db
src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 06e402ddf10a10953b74ac6d764fa3f614c4d9b9
src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 0a76e43ee6f014132bdd6e7f63395335af068846
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 589cab3467d0856444b767bd1e1a48b63c6c2d42
src/main/java/org/apache/aurora/scheduler/http/Maintenance.java d780ed699199751c8afb80f761e1ed957912c8c1
src/main/java/org/apache/aurora/scheduler/http/Slaves.java 4c26db425e56bd83612843ad4f78f3005c03b8d1
src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 332598f5fd6a9307b3fb853ffb0494146cc78484
src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 6aa3e1b4c39da1c32eafb796a940fe9f0478cd2d
src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 6b0068cecead659cdde1129bf53616bcce95e578
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 39f47127602a7927f07156a1b4c8d009b428f814
src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 0b4e22a02c06adc711ec60b172a1075efb9d49f7
src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 796dca3c66e4e389c7d9cf56a12eaee854309f7b
src/main/java/org/apache/aurora/scheduler/storage/mem/MemAttributeStore.java ff9e45cca6f38ba33398a40ebf48759b98662034
src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java da4eefab7db1f7ac476f81c3aea090638d0aa521
src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 3578bb35aa642b0679ee017b79dbcf6591235d94
src/test/java/org/apache/aurora/scheduler/filter/AttributeAggregateTest.java e2d9298e4da97b0934fd39a0f315ec0271efde16
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java c2c05cd21c8c51b8cf92e28925fd8b6cdae0036e
src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java 4656317405506291ee13a7b760f24a6f832f2754
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 53e5749fe4f9ca573d5930a05f3952cb92dbd843
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 5763fd0cb5ef4871e60a7d46d5e14e93e417c689
Diff: https://reviews.apache.org/r/22999/diff/
Testing
-------
./gradlew build -Pq
Thanks,
Bill Farner
Re: Review Request 22999: Use immutable types in AttributeStore.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22999/
-----------------------------------------------------------
(Updated June 26, 2014, 8:37 p.m.)
Review request for Aurora and Maxim Khutornenko.
Changes
-------
People -= davmclau, who is on vacation.
Repository: aurora
Description
-------
Prep work for replacing MemAttributeStore with a database-backed store. Immutable types aren't strictly necessary, but it's a good change to make.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/TaskVars.java 75e791709262319a45c1dacd768708e3a2122f67
src/main/java/org/apache/aurora/scheduler/base/Conversions.java 02e57acae30b1b1ea6ef7f041902ab319b5ef88b
src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 1afc6ca036e7f52f81775f029779badfb36e09db
src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 06e402ddf10a10953b74ac6d764fa3f614c4d9b9
src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 0a76e43ee6f014132bdd6e7f63395335af068846
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 589cab3467d0856444b767bd1e1a48b63c6c2d42
src/main/java/org/apache/aurora/scheduler/http/Maintenance.java d780ed699199751c8afb80f761e1ed957912c8c1
src/main/java/org/apache/aurora/scheduler/http/Slaves.java 4c26db425e56bd83612843ad4f78f3005c03b8d1
src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 332598f5fd6a9307b3fb853ffb0494146cc78484
src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 6aa3e1b4c39da1c32eafb796a940fe9f0478cd2d
src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 6b0068cecead659cdde1129bf53616bcce95e578
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 39f47127602a7927f07156a1b4c8d009b428f814
src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 0b4e22a02c06adc711ec60b172a1075efb9d49f7
src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 796dca3c66e4e389c7d9cf56a12eaee854309f7b
src/main/java/org/apache/aurora/scheduler/storage/mem/MemAttributeStore.java ff9e45cca6f38ba33398a40ebf48759b98662034
src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java da4eefab7db1f7ac476f81c3aea090638d0aa521
src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 3578bb35aa642b0679ee017b79dbcf6591235d94
src/test/java/org/apache/aurora/scheduler/filter/AttributeAggregateTest.java e2d9298e4da97b0934fd39a0f315ec0271efde16
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java c2c05cd21c8c51b8cf92e28925fd8b6cdae0036e
src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java 4656317405506291ee13a7b760f24a6f832f2754
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 53e5749fe4f9ca573d5930a05f3952cb92dbd843
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 5763fd0cb5ef4871e60a7d46d5e14e93e417c689
Diff: https://reviews.apache.org/r/22999/diff/
Testing
-------
./gradlew build -Pq
Thanks,
Bill Farner
Re: Review Request 22999: Use immutable types in AttributeStore.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22999/#review46761
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On June 26, 2014, 4:45 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22999/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 4:45 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Prep work for replacing MemAttributeStore with a database-backed store. Immutable types aren't strictly necessary, but it's a good change to make.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 75e791709262319a45c1dacd768708e3a2122f67
> src/main/java/org/apache/aurora/scheduler/base/Conversions.java 02e57acae30b1b1ea6ef7f041902ab319b5ef88b
> src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 1afc6ca036e7f52f81775f029779badfb36e09db
> src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 06e402ddf10a10953b74ac6d764fa3f614c4d9b9
> src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 0a76e43ee6f014132bdd6e7f63395335af068846
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 589cab3467d0856444b767bd1e1a48b63c6c2d42
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java d780ed699199751c8afb80f761e1ed957912c8c1
> src/main/java/org/apache/aurora/scheduler/http/Slaves.java 4c26db425e56bd83612843ad4f78f3005c03b8d1
> src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 332598f5fd6a9307b3fb853ffb0494146cc78484
> src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 6aa3e1b4c39da1c32eafb796a940fe9f0478cd2d
> src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 6b0068cecead659cdde1129bf53616bcce95e578
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 39f47127602a7927f07156a1b4c8d009b428f814
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 0b4e22a02c06adc711ec60b172a1075efb9d49f7
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 796dca3c66e4e389c7d9cf56a12eaee854309f7b
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemAttributeStore.java ff9e45cca6f38ba33398a40ebf48759b98662034
> src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java da4eefab7db1f7ac476f81c3aea090638d0aa521
> src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 3578bb35aa642b0679ee017b79dbcf6591235d94
> src/test/java/org/apache/aurora/scheduler/filter/AttributeAggregateTest.java e2d9298e4da97b0934fd39a0f315ec0271efde16
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java c2c05cd21c8c51b8cf92e28925fd8b6cdae0036e
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java 4656317405506291ee13a7b760f24a6f832f2754
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 53e5749fe4f9ca573d5930a05f3952cb92dbd843
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 5763fd0cb5ef4871e60a7d46d5e14e93e417c689
>
> Diff: https://reviews.apache.org/r/22999/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Bill Farner
>
>