[GitHub] [zeppelin] liuxunorg commented on a change in pull request #3430: [ZEPPELIN-4312] enable livy to run as remote interpreter in docker

[GitBox <gi...@apache.org>]

liuxunorg commented on a change in pull request #3430: [ZEPPELIN-4312] enable livy to run as remote interpreter in docker
URL: https://github.com/apache/zeppelin/pull/3430#discussion_r317195248
 
 

 ##########
 File path: zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java
 ##########
 @@ -416,14 +417,18 @@ private void copyRunFileToContainer(String containerId)
       intpKeytab = properties.getProperty("submarine.hadoop.keytab", "");
     }
     if (StringUtils.isBlank(intpKeytab)) {
-      // 3.4) jdbc interpreter properties keytab file
+      // 3.4) livy interpreter properties keytab file
+      intpKeytab = properties.getProperty("zeppelin.livy.keytab", "");
+    }
+    if (StringUtils.isBlank(intpKeytab)) {
+      // 3.5) jdbc interpreter properties keytab file
 
 Review comment:
   Because the key table property names set by each interpreter are different, in `DockerInterpreterProcess.java`, the keytab file is now copied to the container in this way.
   Let the interpreter in the container also be authenticated properly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services