You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "nlu90 (GitHub)" <gi...@apache.org> on 2018/08/23 00:59:49 UTC
[GitHub] [incubator-heron] nlu90 opened pull request #3005: fix
building problem with source tarball
When building with the release candidate source tarball, we found it fails with the following issue:
```
ERROR: Process exited with status 1: Process exited with status 1
fatal: Not a git repository (or any of the parent directories): .git
Failed to run command to check head: git rev-parse --abbrev-ref HEAD
INFO: Elapsed time: 431.371s, Critical Path: 143.15s
FAILED: Build did NOT complete successfully
```
This is because the `scripts/release/status.sh` script relies on some git information while the source tarball excludes `.git` directory.
This PR fixes the building failure issue and will generate the following version information when the heron client is built with a source tar ball.
```
[tw-mbp-nlu incubator-heron-v-0.20.0-incubating-candidate-2]$ ~/.heron/bin/heron version
heron.build.git.revision : incubator-heron-v-0.20.0-incubating-candidate-2
heron.build.git.status : Clean
heron.build.host : tw-mbp-nlu
heron.build.time : Wed Aug 22 17:33:58 PDT 2018
heron.build.timestamp : 1534984438000
heron.build.user : nlu
heron.build.version : incubator-heron-v-0.20.0-incubating-candidate-2
```
[ Full content available at: https://github.com/apache/incubator-heron/pull/3005 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-heron] nwangtw commented on pull request #3005:
fix building problem with source tarball
Posted by "nwangtw (GitHub)" <gi...@apache.org>.
suggest to follow the convention in this file, put "then" in the next line.
[ Full content available at: https://github.com/apache/incubator-heron/pull/3005 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-heron] nlu90 closed pull request #3005: fix
building problem with source tarball
Posted by "nlu90 (GitHub)" <gi...@apache.org>.
[ pull request closed by nlu90 ]
[ Full content available at: https://github.com/apache/incubator-heron/pull/3005 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-heron] nwangtw commented on pull request #3005:
fix building problem with source tarball
Posted by "nwangtw (GitHub)" <gi...@apache.org>.
add a space between ".git" and "]"
[ Full content available at: https://github.com/apache/incubator-heron/pull/3005 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-heron] nlu90 commented on issue #3005: fix
building problem with source tarball
Posted by "nlu90 (GitHub)" <gi...@apache.org>.
@nwangtw Please take a look.
[ Full content available at: https://github.com/apache/incubator-heron/pull/3005 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org