You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Juergen Donnerstag (JIRA)" <ji...@apache.org> on 2011/01/21 00:03:43 UTC
[jira] Created: (WICKET-3359) ITab.getPanel() should be able to
return Panel or Fragment; not just Panel
ITab.getPanel() should be able to return Panel or Fragment; not just Panel
--------------------------------------------------------------------------
Key: WICKET-3359
URL: https://issues.apache.org/jira/browse/WICKET-3359
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5-M3
Reporter: Juergen Donnerstag
Assignee: Juergen Donnerstag
> Findings (I can also create jira issues for all of them, just let me know):
> 1) based on Migration Guide 1.5, TabbedPanel improvement:
> 'ITab.getPanel() now returns WebMarkupContainerWithAssociatedMarkup instead
> of Panel so it is now possible to create tabs using Fragments or Panels
> rather then just Panels.'
>
> WebMarkupContainerWithAssociatedMarkup does not exists anymore and
> ITab.getPanel() returns Panel again. so it is no longer possible to use
> Fragments directly.
>
I kind try to fix that. There was no test case (or example) and from
the name getPanel() it wasn't obvious to me that Fragments can also be
an option. And you are right WebMarkupContainerWithAssociatedMarkup is
gone lately. The return type should than probably be
WebMarkupContainer as Panel or Fragment are now merely "mixins". A
Jira issue for that with a testcase or quickstart would be great.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3359) ITab.getPanel() should be able to
return Panel or Fragment; not just Panel
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-3359.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC2
> ITab.getPanel() should be able to return Panel or Fragment; not just Panel
> --------------------------------------------------------------------------
>
> Key: WICKET-3359
> URL: https://issues.apache.org/jira/browse/WICKET-3359
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Juergen Donnerstag
> Assignee: Juergen Donnerstag
> Fix For: 1.5-RC2
>
>
> > Findings (I can also create jira issues for all of them, just let me know):
> > 1) based on Migration Guide 1.5, TabbedPanel improvement:
> > 'ITab.getPanel() now returns WebMarkupContainerWithAssociatedMarkup instead
> > of Panel so it is now possible to create tabs using Fragments or Panels
> > rather then just Panels.'
> >
> > WebMarkupContainerWithAssociatedMarkup does not exists anymore and
> > ITab.getPanel() returns Panel again. so it is no longer possible to use
> > Fragments directly.
> >
> I kind try to fix that. There was no test case (or example) and from
> the name getPanel() it wasn't obvious to me that Fragments can also be
> an option. And you are right WebMarkupContainerWithAssociatedMarkup is
> gone lately. The return type should than probably be
> WebMarkupContainer as Panel or Fragment are now merely "mixins". A
> Jira issue for that with a testcase or quickstart would be great.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.