You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by Garrett Rooney <ro...@electricjellyfish.net> on 2006/01/03 05:08:41 UTC

Re: svn commit: r365376 - /httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c

On 1/2/06, jim@apache.org <ji...@apache.org> wrote:
> Author: jim
> Date: Mon Jan  2 08:52:58 2006
> New Revision: 365376
>
> URL: http://svn.apache.org/viewcvs?rev=365376&view=rev
> Log:
> Avoid magic numbers. Since we are reading the header, let's
> be explicit about it. Also removes the need to clean up
> the readbuf again, and any potential for confusion on
> what we are doing ;)

Um, doesn't this assume that there's no padding in the compiler's
layout of the struct?  Is that safe to do?  I've always been under the
impression that relying on such things is not portable.  If nothing
else we should probably have a compile time check that it's size == 8,
or something...

-garrett