You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2015/07/29 16:49:31 UTC
[jclouds] Fix a small softlayer bug that triggers a guava 19 rc
bugcheck. (#831)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/831
-- Commit Summary --
* Fix a small softlayer bug that triggers a guava 19 rc bugcheck.
-- File Changes --
M providers/softlayer/src/main/java/org/jclouds/softlayer/compute/strategy/SoftLayerComputeServiceAdapter.java (2)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/831.patch
https://github.com/jclouds/jclouds/pull/831.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/831
Re: [jclouds] Fix a small softlayer bug that triggers a guava 19 rc
bugcheck. (#831)
Posted by Zack Shoylev <no...@github.com>.
Closed #831.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/831#event-368454287
Re: [jclouds] Fix a small softlayer bug that triggers a guava 19 rc
bugcheck. (#831)
Posted by Andrea Turli <no...@github.com>.
> @@ -272,7 +272,7 @@ public int compare(Hardware h1, Hardware h2) {
> .compare(getBootableDeviceType(h1), getBootableDeviceType(h2));
> if (!volumes1.isEmpty() && !volumes2.isEmpty() && volumes1.size() == volumes2.size()) {
@andrewgaul thanks for the comment but I'm not sure I got your suggestion. Could you rephrase it, please?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/831/files#r35797046
Re: [jclouds] Fix a small softlayer bug that triggers a guava 19 rc
bugcheck. (#831)
Posted by Andrew Gaul <no...@github.com>.
> @@ -272,7 +272,7 @@ public int compare(Hardware h1, Hardware h2) {
> .compare(getBootableDeviceType(h1), getBootableDeviceType(h2));
> if (!volumes1.isEmpty() && !volumes2.isEmpty() && volumes1.size() == volumes2.size()) {
@andreaturli Consider
h1: cores=1, ram=256, etc., volumes = [volume(type=FOO)]
h2: cores=1, ram=256, etc., volumes = []
These will compare to 0 currently. I expect them to compare to either -1 or +1 since they are different.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/831/files#r35804166
Re: [jclouds] Fix a small softlayer bug that triggers a guava 19 rc
bugcheck. (#831)
Posted by Zack Shoylev <no...@github.com>.
merged and backported
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/831#issuecomment-125986704
Re: [jclouds] Fix a small softlayer bug that triggers a guava 19 rc
bugcheck. (#831)
Posted by Andrew Gaul <no...@github.com>.
> @@ -272,7 +272,7 @@ public int compare(Hardware h1, Hardware h2) {
> .compare(getBootableDeviceType(h1), getBootableDeviceType(h2));
> if (!volumes1.isEmpty() && !volumes2.isEmpty() && volumes1.size() == volumes2.size()) {
@andreaturli Outside the scope of this commit, but this can't be right -- two otherwise identical objects, one with and without a volume, will compare to zero instead of -1 or +1.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/831/files#r35772411
Re: [jclouds] Fix a small softlayer bug that triggers a guava 19 rc
bugcheck. (#831)
Posted by Ignasi Barrera <no...@github.com>.
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/831#issuecomment-125978955
Re: [jclouds] Fix a small softlayer bug that triggers a guava 19 rc
bugcheck. (#831)
Posted by Andrea Turli <no...@github.com>.
> @@ -272,7 +272,7 @@ public int compare(Hardware h1, Hardware h2) {
> .compare(getBootableDeviceType(h1), getBootableDeviceType(h2));
> if (!volumes1.isEmpty() && !volumes2.isEmpty() && volumes1.size() == volumes2.size()) {
I see your point, I will fix it later! thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/831/files#r35807336