[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35085: [SPARK-37618][CORE] Remove shuffle blocks using the shuffle service for released executors

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #35085:
URL: https://github.com/apache/spark/pull/35085#discussion_r814407105



##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -659,6 +659,14 @@ package object config {
       .booleanConf
       .createWithDefault(false)
 
+  private[spark] val SHUFFLE_SERVICE_REMOVE_SHUFFLE_ENABLED =
+    ConfigBuilder("spark.shuffle.service.remove.shuffle.enabled")

Review comment:
       Could you adjust config name? If you use `.`, it creates a namespace. For example, we don't have any other configuration at `spark.shuffle.service.remove.` level. If there is no other future plan, please reduce the depth of level.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org