You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "kuszz (via GitHub)" <gi...@apache.org> on 2024/07/09 03:40:44 UTC
[PR] Add user in heartbeat of RssShuffleManager [incubator-uniffle]
kuszz opened a new pull request, #1876:
URL: https://github.com/apache/incubator-uniffle/pull/1876
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
add user in AppHeartBeatRequest
### Why are the changes needed?
if Coordinator restarts, the RssShuffleManager will not reregister, and user will be lost in heartbeat.
Fix: #1875
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Exsiting UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] Add user in heartbeat of RssShuffleManager [incubator-uniffle]
Posted by "kuszz (via GitHub)" <gi...@apache.org>.
kuszz commented on code in PR #1876:
URL: https://github.com/apache/incubator-uniffle/pull/1876#discussion_r1677378642
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/ApplicationManager.java:
##########
@@ -145,12 +145,12 @@ public void registerApplicationInfo(String appId, String user) {
}
}
- public void refreshAppId(String appId) {
- String user = appIdToUser.get(appId);
+ public void refreshAppId(String appId, String user) {
// compatible with lower version clients
- if (user == null) {
Review Comment:
> How to handle the case `user == null`? Because there may be existing legacy clients.
When the user field is not specified in legacy clients, the value will be empty instead of null. So if coordinator restarts, it actually calls registerApplicationInfo(appId, "").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] Add user in heartbeat of RssShuffleManager [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1876:
URL: https://github.com/apache/incubator-uniffle/pull/1876#issuecomment-2216748744
## Test Results
2 657 files ±0 2 657 suites ±0 5h 30m 31s :stopwatch: +32s
946 tests ±0 944 :white_check_mark: ±0 1 :zzz: ±0 1 :x: +1
11 799 runs ±0 11 783 :white_check_mark: ±0 15 :zzz: ±0 1 :x: +1
For more details on these failures, see [this check](https://github.com/apache/incubator-uniffle/runs/27200968633).
Results for commit 74935310. ± Comparison against base commit e18f81c1.
[test-results]:data:application/gzip;base64,H4sIAMvfjGYC/1XMyw6DIBCF4VcxrLtghBHoyzSUS0LqpUFYmb57R6PWLs/H8C8spj7M7N60Hapbw+aaynX7mm1J00gCRgsgoveyXhjZHesxV+c2kj96pff664RoU/8HIecpk3CSXMe1CaCM2ecRJdPitL2KB1yq275G3TQMqdBgShqBAnjrvbcBtHpyzz0i1+g0dNECchkDss8XXKiteRIBAAA=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] Add user in heartbeat of RssShuffleManager [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1876:
URL: https://github.com/apache/incubator-uniffle/pull/1876#discussion_r1673908274
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/ApplicationManager.java:
##########
@@ -145,12 +145,12 @@ public void registerApplicationInfo(String appId, String user) {
}
}
- public void refreshAppId(String appId) {
- String user = appIdToUser.get(appId);
+ public void refreshAppId(String appId, String user) {
// compatible with lower version clients
- if (user == null) {
Review Comment:
How to handle the case `user == null`? Because there may be existing legacy clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org