You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/09/05 08:49:36 UTC
[GitHub] zeppelin pull request #2566: [ZEPPELIN-2903] Make setting of working directo...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2566
[ZEPPELIN-2903] Make setting of working directory to user-home optional for shell interpreter
### What is this PR for?
With ZEPPELIN-2841, it had changed the default working directory of Shell Interpreter from the relative path where Zeppelin is running to user-home. This is to make the configuration optional.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2903
### How should this be tested?
by default when the user runs shell interpreter and executes `pwd` will the path where Zeppelin server is running, but when `shell.working.directory.user.home` is set to true in Zeppelin's interpreter setting, it will point to the user's home directory by which the interpreter is running.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2903
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2566.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2566
----
commit 9164ed2c0fa8b72fde82240a9dfa878e99bc669e
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-09-05T08:45:03Z
Make setting of working directory to user-home optional for shell interpreter
----
---
[GitHub] zeppelin issue #2566: [ZEPPELIN-2903] Make setting of working directory to u...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2566
Merging this to master and branch-0.7 if no more discussion.
---
[GitHub] zeppelin issue #2566: [ZEPPELIN-2903] Make setting of working directory to u...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/2566
LGTM
---
[GitHub] zeppelin pull request #2566: [ZEPPELIN-2903] Make setting of working directo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2566
---
[GitHub] zeppelin pull request #2566: [ZEPPELIN-2903] Make setting of working directo...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/2566
---
[GitHub] zeppelin issue #2566: [ZEPPELIN-2903] Make setting of working directory to u...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2566
I think it's realistic solution we can choose. LGTM
---
[GitHub] zeppelin pull request #2566: [ZEPPELIN-2903] Make setting of working directo...
Posted by prabhjyotsingh <gi...@git.apache.org>.
GitHub user prabhjyotsingh reopened a pull request:
https://github.com/apache/zeppelin/pull/2566
[ZEPPELIN-2903] Make setting of working directory to user-home optional for shell interpreter
### What is this PR for?
With ZEPPELIN-2841, it had changed the default working directory of Shell Interpreter from the relative path where Zeppelin is running to user-home. This is to make the configuration optional.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2903
### How should this be tested?
by default when the user runs shell interpreter and executes `pwd` will the path where Zeppelin server is running, but when `shell.working.directory.user.home` is set to true in Zeppelin's interpreter setting, it will point to the user's home directory by which the interpreter is running.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2903
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2566.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2566
----
commit 9164ed2c0fa8b72fde82240a9dfa878e99bc669e
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-09-05T08:45:03Z
Make setting of working directory to user-home optional for shell interpreter
commit 9934df52a6e1fb17fb069235449baca101ba17a2
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-09-05T17:50:15Z
add doc for shell.working.directory.user.home
----
---