You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsuyoshi OZAWA (JIRA)" <ji...@apache.org> on 2013/08/02 03:47:49 UTC
[jira] [Resolved] (HADOOP-9779) create constant
RpcConstants.CLIENT_ID_LENGTH rather than hard-coding 16 everywhere
[ https://issues.apache.org/jira/browse/HADOOP-9779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsuyoshi OZAWA resolved HADOOP-9779.
------------------------------------
Resolution: Duplicate
Close as a duplicated issue of HDFS-5025.
> create constant RpcConstants.CLIENT_ID_LENGTH rather than hard-coding 16 everywhere
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-9779
> URL: https://issues.apache.org/jira/browse/HADOOP-9779
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Tsuyoshi OZAWA
> Priority: Minor
> Attachments: HADOOP-9779.1.patch, HADOOP-9779.2.patch
>
>
> We should create a constant RpcConstants.CLIENT_ID_LENGTH rather than hard-coding the number 16 everywhere.
> Sun Java coding style convention 10.3:
> bq. Numerical constants (literals) should not be coded directly, except for -1, 0, and 1, which can appear in a for loop as counter values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira