You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2023/03/28 05:53:34 UTC
[GitHub] [doris] Mryange opened a new pull request, #18166: Delete the environment variable enable_vectorized_engine
Mryange opened a new pull request, #18166:
URL: https://github.com/apache/doris/pull/18166
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1493602075
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1498391208
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1498705806
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1498390999
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1498629392
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #18166:
URL: https://github.com/apache/doris/pull/18166#discussion_r1156693709
##########
be/src/vec/exec/format/orc/vorc_reader.h:
##########
@@ -147,13 +147,19 @@ class OrcReader : public GenericReader {
Status _decode_explicit_decimal_column(const std::string& col_name,
const MutableColumnPtr& data_column,
const DataTypePtr& data_type,
- DecimalScaleParams& scale_params,
orc::ColumnVectorBatch* cvb, size_t num_values) {
OrcColumnType* data = dynamic_cast<OrcColumnType*>(cvb);
if (data == nullptr) {
return Status::InternalError("Wrong data type for colum '{}'", col_name);
}
- _init_decimal_converter<DecimalPrimitiveType>(data_type, scale_params, data->scale);
+ if (_decimal_scale_params_index >= _decimal_scale_params.size()) {
+ DecimalScaleParams temp_scale_params;
+ _init_decimal_converter<DecimalPrimitiveType>(data_type, temp_scale_params,
+ data->scale);
+ _decimal_scale_params.emplace_back(std::move(temp_scale_params));
Review Comment:
warning: std::move of the variable 'temp_scale_params' of the trivially-copyable type 'doris::vectorized::DecimalScaleParams' has no effect; remove std::move() [performance-move-const-arg]
```suggestion
_decimal_scale_params.emplace_back(temp_scale_params);
```
##########
be/src/olap/column_predicate.h:
##########
@@ -121,6 +121,21 @@ struct PredicateTypeTraits {
}
};
+#define EVALUATE_BY_SELECTOR(EVALUATE_IMPL_WITH_NULL_MAP, EVALUATE_IMPL_WITHOUT_NULL_MAP) \
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define EVALUATE_BY_SELECTOR(EVALUATE_IMPL_WITH_NULL_MAP, EVALUATE_IMPL_WITHOUT_NULL_MAP) \
^
```
##########
be/src/vec/exec/scan/pip_scanner_context.h:
##########
@@ -57,6 +57,15 @@ class PipScannerContext : public vectorized::ScannerContext {
}
}
_current_used_bytes -= (*block)->allocated_bytes();
+ {
+ if (has_enough_space_in_blocks_queue()) {
+ std::unique_lock<std::mutex> l(_transfer_lock);
+ auto submit_st = _scanner_scheduler->submit(this);
Review Comment:
warning: member access into incomplete type 'doris::vectorized::ScannerScheduler' [clang-diagnostic-error]
```cpp
auto submit_st = _scanner_scheduler->submit(this);
^
```
**be/src/runtime/exec_env.h:31:** forward declaration of 'doris::vectorized::ScannerScheduler'
```cpp
class ScannerScheduler;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1495306000
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #18166:
URL: https://github.com/apache/doris/pull/18166#discussion_r1150217652
##########
gensrc/thrift/PaloInternalService.thrift:
##########
@@ -151,8 +151,6 @@ struct TQueryOptions {
// if the right table is greater than this value in the hash join, we will ignore IN filter
34: optional i32 runtime_filter_max_in_num = 1024;
- // whether enable vectorized engine
- 41: optional bool enable_vectorized_engine = false
Review Comment:
change the variable to `true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1495307617
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1495453589
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1491169543
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1489968728
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1489995205
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18166: Delete the environment variable enable_vectorized_engine
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1486260036
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #18166:
URL: https://github.com/apache/doris/pull/18166#discussion_r1150217353
##########
fe/fe-core/src/main/java/org/apache/doris/planner/StreamLoadPlanner.java:
##########
@@ -273,7 +273,6 @@ public TExecPlanFragmentParams plan(TUniqueId loadId) throws UserException {
queryOptions.setMemLimit(taskInfo.getMemLimit());
// for stream load, we use exec_mem_limit to limit the memory usage of load channel.
queryOptions.setLoadMemLimit(taskInfo.getMemLimit());
- queryOptions.setEnableVectorizedEngine(Config.enable_vectorized_load);
Review Comment:
do not change load
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1488499209
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zclllyybb commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1486878441
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1490091841
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1493814131
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1498415886
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee merged pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #18166:
URL: https://github.com/apache/doris/pull/18166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1499865588
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1495455070
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1493601220
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1495309865
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1486459156
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #18166:
URL: https://github.com/apache/doris/pull/18166#discussion_r1151297159
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1325,14 +1321,6 @@ public void setRuntimeFilterMaxInNum(int runtimeFilterMaxInNum) {
this.runtimeFilterMaxInNum = runtimeFilterMaxInNum;
}
- public boolean enableVectorizedEngine() {
Review Comment:
Please keep this variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1487851847
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zclllyybb commented on pull request #18166: Delete the environment variable enable_vectorized_engine
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1486268346
please fix your title and describe your change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1493585864
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1498629427
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18166:
URL: https://github.com/apache/doris/pull/18166#issuecomment-1498702569
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org