You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by po...@apache.org on 2020/06/14 21:24:44 UTC
[airflow] branch master updated: Make airflow/models/skipmixin.py
Pylint compatible (#9289)
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 4c7f4b4 Make airflow/models/skipmixin.py Pylint compatible (#9289)
4c7f4b4 is described below
commit 4c7f4b40d718b7a0ef2cae1ac07140f51ea49e27
Author: Kaxil Naik <ka...@gmail.com>
AuthorDate: Sun Jun 14 22:24:17 2020 +0100
Make airflow/models/skipmixin.py Pylint compatible (#9289)
---
airflow/models/skipmixin.py | 5 +++--
scripts/ci/pylint_todo.txt | 2 --
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/airflow/models/skipmixin.py b/airflow/models/skipmixin.py
index 5162328..b3c5530 100644
--- a/airflow/models/skipmixin.py
+++ b/airflow/models/skipmixin.py
@@ -35,6 +35,7 @@ XCOM_SKIPMIXIN_FOLLOWED = "followed"
class SkipMixin(LoggingMixin):
+ """ A Mixin to skip Tasks Instances """
def _set_state_to_skipped(self, dag_run, execution_date, tasks, session):
"""
Used internally to set state of task instances to skipped from the same dag run.
@@ -133,9 +134,9 @@ class SkipMixin(LoggingMixin):
# Also check downstream tasks of the branch task. In case the task to skip
# is also a downstream task of the branch task, we exclude it from skipping.
branch_downstream_task_ids = set() # type: Set[str]
- for b in branch_task_ids:
+ for branch_task_id in branch_task_ids:
branch_downstream_task_ids.update(
- dag.get_task(b).get_flat_relative_ids(upstream=False)
+ dag.get_task(branch_task_id).get_flat_relative_ids(upstream=False)
)
skip_tasks = [
diff --git a/scripts/ci/pylint_todo.txt b/scripts/ci/pylint_todo.txt
index fdc4710..12b1134 100644
--- a/scripts/ci/pylint_todo.txt
+++ b/scripts/ci/pylint_todo.txt
@@ -11,9 +11,7 @@
./airflow/models/dagrun.py
./airflow/models/errors.py
./airflow/models/kubernetes.py
-./airflow/models/log.py
./airflow/models/pool.py
-./airflow/models/skipmixin.py
./airflow/models/slamiss.py
./airflow/models/taskinstance.py
./airflow/models/variable.py