You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/16 22:02:09 UTC
[GitHub] [incubator-superset] kgabryje opened a new pull request #11719: fix: ModalTriggers styling in SqlLab
kgabryje opened a new pull request #11719:
URL: https://github.com/apache/incubator-superset/pull/11719
### SUMMARY
Change trigger node from ModalTrigger from div back to span. Added `display: inline-block` in Menu, so that the whole menu item is clickable.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: https://github.com/apache/incubator-superset/issues/11715
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
CC: @mistercrunch @junlincc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #11719: fix: ModalTriggers styling in SqlLab
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #11719:
URL: https://github.com/apache/incubator-superset/pull/11719
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org