You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "bobhan1 (via GitHub)" <gi...@apache.org> on 2024/09/05 09:48:46 UTC

[PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

bobhan1 opened a new pull request, #40436:
URL: https://github.com/apache/doris/pull/40436

   ## Proposed changes
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2334064371

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 37719 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit a6bfebf7ffa636b27ce3287faea443e75b809b71, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17635	4960	4312	4312
   q2	2009	208	211	208
   q3	10420	1153	1110	1110
   q4	10130	671	689	671
   q5	7721	2826	2833	2826
   q6	228	139	137	137
   q7	970	607	601	601
   q8	9311	2066	2059	2059
   q9	7125	6462	6530	6462
   q10	6995	2184	2143	2143
   q11	460	245	240	240
   q12	395	222	223	222
   q13	18670	3118	3102	3102
   q14	279	246	240	240
   q15	528	487	480	480
   q16	511	442	428	428
   q17	984	714	700	700
   q18	7516	6844	6799	6799
   q19	1389	1059	989	989
   q20	654	342	336	336
   q21	4463	3039	2675	2675
   q22	1089	985	979	979
   Total cold run time: 109482 ms
   Total hot run time: 37719 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4363	4240	4238	4238
   q2	384	262	275	262
   q3	2889	2694	2719	2694
   q4	1943	1663	1662	1662
   q5	5593	5702	5672	5672
   q6	232	141	134	134
   q7	2251	1874	1812	1812
   q8	3367	3521	3433	3433
   q9	8924	8721	8723	8721
   q10	3606	3347	3325	3325
   q11	610	512	510	510
   q12	832	665	636	636
   q13	17209	3274	3315	3274
   q14	322	283	278	278
   q15	578	499	500	499
   q16	547	491	504	491
   q17	1861	1575	1534	1534
   q18	8099	7789	7854	7789
   q19	1702	1489	1584	1489
   q20	2155	1820	1835	1820
   q21	5799	5497	5532	5497
   q22	1157	1076	1074	1074
   Total cold run time: 74423 ms
   Total hot run time: 56844 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2332167196

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 38248 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 15b35fe59d496e0ef407042460ee968e890a6379, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17692	4581	4422	4422
   q2	2372	200	196	196
   q3	10435	1184	1177	1177
   q4	10152	714	737	714
   q5	7749	2854	2804	2804
   q6	236	137	137	137
   q7	964	612	604	604
   q8	9332	2047	2073	2047
   q9	7255	6551	6580	6551
   q10	6996	2173	2219	2173
   q11	455	243	255	243
   q12	397	221	223	221
   q13	17962	3044	3111	3044
   q14	291	244	260	244
   q15	537	488	470	470
   q16	525	434	427	427
   q17	980	786	671	671
   q18	7290	6960	6782	6782
   q19	1392	1052	1138	1052
   q20	684	347	340	340
   q21	3967	3009	2916	2916
   q22	1110	1013	1044	1013
   Total cold run time: 108773 ms
   Total hot run time: 38248 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4336	4304	4319	4304
   q2	376	271	276	271
   q3	2865	2626	2650	2626
   q4	1927	1650	1643	1643
   q5	5384	5366	5375	5366
   q6	221	132	131	131
   q7	2060	1732	1732	1732
   q8	3213	3349	3347	3347
   q9	8417	8415	8340	8340
   q10	3461	3177	3154	3154
   q11	612	497	500	497
   q12	795	600	602	600
   q13	11838	3087	3107	3087
   q14	318	272	286	272
   q15	536	470	484	470
   q16	515	476	477	476
   q17	1808	1497	1479	1479
   q18	7834	7440	7390	7390
   q19	1669	1695	1525	1525
   q20	2019	1815	1828	1815
   q21	5626	5271	5322	5271
   q22	1114	1029	1039	1029
   Total cold run time: 66944 ms
   Total hot run time: 54825 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2334013570

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2339767203

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2331710430

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2331087798

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2331397607

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 32.2 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit d5b6c153141b231f0feeeee8cac5c2e4cc18621e, data reload: false
   
   query1	0.04	0.05	0.04
   query2	0.09	0.04	0.04
   query3	0.22	0.05	0.05
   query4	1.68	0.08	0.07
   query5	0.50	0.48	0.51
   query6	1.14	0.73	0.74
   query7	0.02	0.02	0.02
   query8	0.05	0.04	0.05
   query9	0.55	0.50	0.48
   query10	0.54	0.54	0.53
   query11	0.15	0.12	0.12
   query12	0.16	0.13	0.12
   query13	0.59	0.59	0.58
   query14	2.11	2.07	2.05
   query15	0.84	0.83	0.84
   query16	0.35	0.37	0.37
   query17	0.97	1.04	1.07
   query18	0.21	0.20	0.20
   query19	1.86	1.78	1.80
   query20	0.01	0.02	0.01
   query21	15.39	0.65	0.66
   query22	4.75	5.98	2.04
   query23	18.26	1.37	1.33
   query24	2.10	0.23	0.22
   query25	0.14	0.08	0.07
   query26	0.28	0.18	0.18
   query27	0.08	0.08	0.08
   query28	13.27	1.01	1.00
   query29	12.67	3.40	3.33
   query30	0.24	0.06	0.06
   query31	2.87	0.39	0.40
   query32	3.26	0.48	0.49
   query33	2.98	3.00	3.05
   query34	17.09	4.36	4.37
   query35	4.40	4.43	4.38
   query36	0.67	0.47	0.50
   query37	0.18	0.16	0.15
   query38	0.16	0.14	0.15
   query39	0.05	0.04	0.04
   query40	0.16	0.13	0.13
   query41	0.09	0.04	0.05
   query42	0.06	0.05	0.04
   query43	0.04	0.04	0.04
   Total cold run time: 111.27 s
   Total hot run time: 32.2 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #40436:
URL: https://github.com/apache/doris/pull/40436#discussion_r1747009503


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/AbstractInsertExecutor.java:
##########
@@ -192,14 +192,18 @@ public void executeSingleInsert(StmtExecutor executor, long jobId) throws Except
             execImpl(executor, jobId);
             checkStrictModeAndFilterRatio();
             int retryTimes = 0;
-            while (retryTimes < Config.mow_insert_into_commit_retry_times) {
+            while (true) {
                 try {
                     onComplete();
                     break;
                 } catch (UserException e) {
                     LOG.warn("failed to commit txn", e);

Review Comment:
   also log txnId jobId  and retrytimes 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2331376366

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 192839 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit d5b6c153141b231f0feeeee8cac5c2e4cc18621e, data reload: false
   
   query1	1249	896	895	895
   query2	6423	1929	1936	1929
   query3	10601	3919	4137	3919
   query4	59485	25595	23254	23254
   query5	5369	492	495	492
   query6	398	162	177	162
   query7	5762	305	298	298
   query8	356	239	230	230
   query9	8813	2517	2507	2507
   query10	474	288	275	275
   query11	17987	15181	15221	15181
   query12	152	113	105	105
   query13	1527	439	404	404
   query14	11151	7463	7029	7029
   query15	233	177	166	166
   query16	7498	469	490	469
   query17	1099	557	569	557
   query18	2065	296	286	286
   query19	288	141	146	141
   query20	123	108	106	106
   query21	207	113	110	110
   query22	4581	4482	4693	4482
   query23	34521	33564	33486	33486
   query24	5946	2835	2835	2835
   query25	546	411	396	396
   query26	692	163	157	157
   query27	1785	279	281	279
   query28	3890	2058	2062	2058
   query29	711	432	427	427
   query30	233	160	160	160
   query31	950	765	775	765
   query32	82	55	55	55
   query33	491	307	295	295
   query34	884	488	483	483
   query35	809	724	732	724
   query36	1103	916	952	916
   query37	152	96	94	94
   query38	4002	3965	3990	3965
   query39	1425	1408	1394	1394
   query40	204	118	118	118
   query41	50	50	46	46
   query42	123	95	100	95
   query43	504	457	464	457
   query44	1093	752	756	752
   query45	202	165	165	165
   query46	1091	748	741	741
   query47	1866	1787	1801	1787
   query48	375	302	310	302
   query49	791	445	457	445
   query50	855	412	419	412
   query51	6989	6799	6800	6799
   query52	98	88	88	88
   query53	251	181	185	181
   query54	565	459	473	459
   query55	77	82	76	76
   query56	284	279	283	279
   query57	1186	1080	1071	1071
   query58	248	251	245	245
   query59	3037	2779	2734	2734
   query60	297	291	289	289
   query61	124	120	121	120
   query62	755	666	651	651
   query63	221	192	188	188
   query64	2945	777	752	752
   query65	3217	3132	3115	3115
   query66	652	362	350	350
   query67	15274	15077	15309	15077
   query68	4321	564	564	564
   query69	408	281	275	275
   query70	1196	1052	1084	1052
   query71	349	275	277	275
   query72	6567	4019	3946	3946
   query73	761	328	331	328
   query74	9157	8787	8941	8787
   query75	3308	2688	2641	2641
   query76	1715	1085	1042	1042
   query77	534	321	319	319
   query78	9793	9449	9050	9050
   query79	2050	533	548	533
   query80	1199	521	494	494
   query81	562	235	233	233
   query82	1265	142	142	142
   query83	243	151	146	146
   query84	255	121	73	73
   query85	917	281	280	280
   query86	307	261	288	261
   query87	4415	4271	4325	4271
   query88	3414	2381	2373	2373
   query89	392	277	286	277
   query90	1689	190	188	188
   query91	129	99	104	99
   query92	62	49	48	48
   query93	2746	536	542	536
   query94	590	280	289	280
   query95	337	261	292	261
   query96	618	271	266	266
   query97	3213	3046	3052	3046
   query98	230	202	197	197
   query99	1550	1276	1276	1276
   Total cold run time: 311729 ms
   Total hot run time: 192839 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2331710489

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2334092177

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 191009 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit a6bfebf7ffa636b27ce3287faea443e75b809b71, data reload: false
   
   query1	1257	945	897	897
   query2	6182	1931	1939	1931
   query3	10641	3939	3950	3939
   query4	60282	26011	23032	23032
   query5	5423	504	510	504
   query6	524	164	162	162
   query7	6480	291	284	284
   query8	335	223	209	209
   query9	8606	2476	2472	2472
   query10	502	289	265	265
   query11	16842	15023	15198	15023
   query12	169	112	107	107
   query13	1629	395	388	388
   query14	11793	7199	7576	7199
   query15	223	172	179	172
   query16	7610	473	545	473
   query17	1146	586	563	563
   query18	1842	289	280	280
   query19	192	148	150	148
   query20	119	112	111	111
   query21	214	107	105	105
   query22	4417	3995	4166	3995
   query23	33432	33142	33343	33142
   query24	5580	2835	2810	2810
   query25	497	385	396	385
   query26	679	156	158	156
   query27	1706	280	279	279
   query28	3718	2045	2022	2022
   query29	634	405	403	403
   query30	237	155	153	153
   query31	936	713	735	713
   query32	69	54	51	51
   query33	527	280	284	280
   query34	870	473	480	473
   query35	809	710	731	710
   query36	1047	929	898	898
   query37	142	99	88	88
   query38	4040	3879	3873	3873
   query39	1443	1403	1392	1392
   query40	205	114	117	114
   query41	50	46	46	46
   query42	123	98	98	98
   query43	518	462	458	458
   query44	1129	744	754	744
   query45	199	165	167	165
   query46	1069	765	771	765
   query47	1856	1774	1800	1774
   query48	374	288	289	288
   query49	773	445	447	445
   query50	835	411	406	406
   query51	7143	6835	6882	6835
   query52	99	92	91	91
   query53	253	181	180	180
   query54	562	450	450	450
   query55	76	102	74	74
   query56	286	264	258	258
   query57	1163	1074	1045	1045
   query58	232	236	223	223
   query59	2913	2757	2676	2676
   query60	290	273	276	273
   query61	104	99	97	97
   query62	762	660	671	660
   query63	225	192	189	189
   query64	2003	705	665	665
   query65	3177	3194	3153	3153
   query66	746	341	334	334
   query67	15265	15119	15135	15119
   query68	3106	581	593	581
   query69	398	296	275	275
   query70	1170	1113	1072	1072
   query71	404	278	306	278
   query72	4697	3997	3777	3777
   query73	735	322	323	322
   query74	9143	8839	8815	8815
   query75	3397	2713	2633	2633
   query76	1976	959	997	959
   query77	523	331	318	318
   query78	9655	8893	9101	8893
   query79	1009	554	546	546
   query80	680	507	529	507
   query81	463	239	232	232
   query82	240	139	147	139
   query83	176	152	154	152
   query84	256	78	74	74
   query85	689	291	283	283
   query86	323	306	300	300
   query87	4375	4367	4357	4357
   query88	2939	2316	2354	2316
   query89	380	292	288	288
   query90	1862	188	193	188
   query91	128	95	99	95
   query92	63	49	50	49
   query93	1047	539	546	539
   query94	643	285	289	285
   query95	300	264	261	261
   query96	582	262	265	262
   query97	3194	3058	3027	3027
   query98	216	200	200	200
   query99	1523	1274	1277	1274
   Total cold run time: 301516 ms
   Total hot run time: 191009 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2332188751

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 187208 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 15b35fe59d496e0ef407042460ee968e890a6379, data reload: false
   
   query1	912	389	384	384
   query2	6501	1983	1889	1889
   query3	6647	213	212	212
   query4	33969	23020	22958	22958
   query5	4184	503	501	501
   query6	258	186	167	167
   query7	4577	298	302	298
   query8	278	217	211	211
   query9	8512	2503	2498	2498
   query10	439	259	259	259
   query11	17117	15025	15067	15025
   query12	151	102	101	101
   query13	1637	394	373	373
   query14	9758	7302	7100	7100
   query15	268	170	177	170
   query16	8166	446	437	437
   query17	1665	580	560	560
   query18	2135	293	290	290
   query19	339	148	150	148
   query20	119	109	113	109
   query21	213	104	106	104
   query22	4455	4130	4259	4130
   query23	34098	33492	33412	33412
   query24	10980	2952	2858	2858
   query25	641	393	407	393
   query26	1353	163	155	155
   query27	2835	284	285	284
   query28	7370	2067	2052	2052
   query29	863	419	433	419
   query30	306	163	149	149
   query31	985	779	798	779
   query32	103	60	61	60
   query33	766	299	294	294
   query34	948	478	475	475
   query35	849	713	709	709
   query36	1077	908	934	908
   query37	161	93	87	87
   query38	4063	3838	3923	3838
   query39	1448	1425	1421	1421
   query40	220	120	117	117
   query41	50	49	47	47
   query42	120	94	97	94
   query43	510	469	460	460
   query44	1234	761	746	746
   query45	196	168	171	168
   query46	1110	712	738	712
   query47	1904	1807	1837	1807
   query48	371	303	297	297
   query49	1055	448	459	448
   query50	832	406	407	406
   query51	7065	6869	6888	6869
   query52	102	89	86	86
   query53	257	192	182	182
   query54	984	473	464	464
   query55	77	74	75	74
   query56	290	262	262	262
   query57	1235	1081	1071	1071
   query58	259	240	250	240
   query59	3027	2809	2700	2700
   query60	308	277	278	277
   query61	126	127	125	125
   query62	821	664	652	652
   query63	229	188	186	186
   query64	5395	709	639	639
   query65	3224	3116	3156	3116
   query66	1450	334	335	334
   query67	15489	15196	15481	15196
   query68	4775	582	560	560
   query69	428	275	265	265
   query70	1096	1136	1115	1115
   query71	419	273	272	272
   query72	6607	3976	3944	3944
   query73	755	322	323	322
   query74	9099	8733	8799	8733
   query75	3508	2692	2651	2651
   query76	2790	1019	959	959
   query77	522	321	315	315
   query78	9796	8959	9043	8959
   query79	2214	528	534	528
   query80	1221	500	488	488
   query81	586	233	229	229
   query82	931	137	143	137
   query83	216	152	147	147
   query84	236	84	75	75
   query85	1375	295	273	273
   query86	447	284	262	262
   query87	4291	4183	4201	4183
   query88	3167	2356	2331	2331
   query89	400	291	288	288
   query90	1833	188	187	187
   query91	125	99	103	99
   query92	72	51	50	50
   query93	1743	560	541	541
   query94	956	297	274	274
   query95	346	249	254	249
   query96	594	263	263	263
   query97	3207	3105	3069	3069
   query98	214	203	198	198
   query99	1529	1250	1296	1250
   Total cold run time: 294584 ms
   Total hot run time: 187208 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2332120910

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2331265000

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2331352137

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 38465 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit d5b6c153141b231f0feeeee8cac5c2e4cc18621e, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17736	4408	4341	4341
   q2	2014	190	198	190
   q3	12060	946	1037	946
   q4	10515	799	732	732
   q5	7733	2867	2863	2863
   q6	229	140	137	137
   q7	969	638	613	613
   q8	9553	2144	2080	2080
   q9	7217	6641	6679	6641
   q10	7173	2339	2411	2339
   q11	502	242	254	242
   q12	404	230	235	230
   q13	18055	3112	3085	3085
   q14	282	255	241	241
   q15	526	492	477	477
   q16	614	516	519	516
   q17	1006	728	687	687
   q18	7802	6804	6855	6804
   q19	1394	1070	981	981
   q20	689	326	338	326
   q21	3922	3107	2997	2997
   q22	1091	997	1016	997
   Total cold run time: 111486 ms
   Total hot run time: 38465 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4386	4264	4281	4264
   q2	375	272	275	272
   q3	2863	2670	2598	2598
   q4	1955	1675	1704	1675
   q5	5711	5643	5778	5643
   q6	235	131	131	131
   q7	2211	1808	1794	1794
   q8	3265	3407	3502	3407
   q9	8815	8768	8766	8766
   q10	3607	3382	3341	3341
   q11	600	508	487	487
   q12	851	650	673	650
   q13	15922	3219	3248	3219
   q14	321	288	304	288
   q15	533	496	470	470
   q16	600	589	576	576
   q17	1838	1558	1555	1555
   q18	8103	7859	7860	7859
   q19	1724	1660	1644	1644
   q20	2177	1881	1930	1881
   q21	5715	5752	5289	5289
   q22	1100	1055	1032	1032
   Total cold run time: 72907 ms
   Total hot run time: 56841 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2332198383

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.61 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 15b35fe59d496e0ef407042460ee968e890a6379, data reload: false
   
   query1	0.05	0.04	0.04
   query2	0.07	0.04	0.04
   query3	0.23	0.05	0.05
   query4	1.68	0.07	0.07
   query5	0.50	0.50	0.50
   query6	1.13	0.73	0.72
   query7	0.02	0.02	0.02
   query8	0.05	0.05	0.04
   query9	0.53	0.50	0.49
   query10	0.54	0.57	0.55
   query11	0.15	0.12	0.11
   query12	0.15	0.12	0.12
   query13	0.59	0.58	0.58
   query14	1.39	1.43	1.42
   query15	0.84	0.81	0.82
   query16	0.38	0.34	0.38
   query17	1.06	1.00	1.05
   query18	0.24	0.21	0.20
   query19	1.98	1.80	1.80
   query20	0.01	0.01	0.01
   query21	15.39	0.67	0.67
   query22	3.85	6.58	2.17
   query23	18.26	1.33	1.24
   query24	2.11	0.26	0.22
   query25	0.15	0.08	0.08
   query26	0.27	0.19	0.18
   query27	0.08	0.08	0.08
   query28	13.20	1.02	1.01
   query29	12.61	3.35	3.28
   query30	0.25	0.05	0.06
   query31	2.92	0.40	0.39
   query32	3.24	0.49	0.48
   query33	2.95	2.97	3.10
   query34	16.81	4.38	4.40
   query35	4.40	4.44	4.42
   query36	0.66	0.47	0.48
   query37	0.19	0.16	0.15
   query38	0.16	0.15	0.15
   query39	0.05	0.04	0.04
   query40	0.17	0.13	0.13
   query41	0.09	0.05	0.06
   query42	0.06	0.05	0.05
   query43	0.04	0.04	0.04
   Total cold run time: 109.5 s
   Total hot run time: 31.61 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2333183365

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40436:
URL: https://github.com/apache/doris/pull/40436#issuecomment-2334102960

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.7 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit a6bfebf7ffa636b27ce3287faea443e75b809b71, data reload: false
   
   query1	0.04	0.04	0.04
   query2	0.07	0.05	0.05
   query3	0.23	0.04	0.05
   query4	1.67	0.07	0.07
   query5	0.50	0.50	0.50
   query6	1.13	0.73	0.73
   query7	0.02	0.01	0.01
   query8	0.05	0.04	0.04
   query9	0.55	0.48	0.48
   query10	0.55	0.57	0.53
   query11	0.15	0.11	0.12
   query12	0.14	0.12	0.12
   query13	0.61	0.60	0.59
   query14	1.37	1.40	1.39
   query15	0.86	0.81	0.84
   query16	0.38	0.36	0.38
   query17	1.05	1.07	1.07
   query18	0.21	0.21	0.20
   query19	1.96	1.88	1.76
   query20	0.01	0.00	0.01
   query21	15.41	0.67	0.65
   query22	4.37	8.04	1.32
   query23	18.31	1.39	1.25
   query24	2.05	0.22	0.23
   query25	0.13	0.09	0.08
   query26	0.27	0.18	0.18
   query27	0.08	0.08	0.08
   query28	13.29	1.02	0.99
   query29	12.63	3.34	3.30
   query30	0.24	0.05	0.06
   query31	2.87	0.41	0.40
   query32	3.22	0.48	0.49
   query33	2.97	2.95	3.01
   query34	17.10	4.39	4.36
   query35	4.44	4.43	4.42
   query36	0.67	0.49	0.48
   query37	0.19	0.15	0.15
   query38	0.15	0.15	0.15
   query39	0.05	0.04	0.04
   query40	0.16	0.13	0.12
   query41	0.10	0.04	0.04
   query42	0.06	0.05	0.05
   query43	0.05	0.04	0.04
   Total cold run time: 110.36 s
   Total hot run time: 30.7 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](merge-on-write) AbstractInsertExecutor should throw exception after running out of retry times [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #40436:
URL: https://github.com/apache/doris/pull/40436


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org