[jira] [Commented] (METRON-1319) Column Metadata REST service should use default indices on empty input

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257623#comment-16257623 ] 

ASF GitHub Bot commented on METRON-1319:
----------------------------------------

GitHub user merrimanr opened a pull request:

    https://github.com/apache/metron/pull/843

    METRON-1319: Column Metadata REST service should use default indices on empty input

    ## Contributor Comments
    This PR adjusts the Column Metadata REST service to use a list of default indices when an empty list is passed in.  This behavior is similar to the search method and keeps the Alerts UI from having to track the current list of available indices.
    
    I added test cases and verified the relevant tests in our Alerts UI end-to-end test now pass.  Still need to spin up full dev and validate there.  Will report back once I have successfully done that but this can be reviewed in the meantime.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merrimanr/incubator-metron METRON-1319

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/843.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #843
    
----
commit ac4d68eea31caa1fa1a8f2f97c4d21256d7220e8
Author: merrimanr <me...@gmail.com>
Date:   2017-11-17T21:36:00Z

    initial commit

----


> Column Metadata REST service should use default indices on empty input
> ----------------------------------------------------------------------
>
>                 Key: METRON-1319
>                 URL: https://issues.apache.org/jira/browse/METRON-1319
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Ryan Merriman
>            Assignee: Ryan Merriman
>
> A bug in the Column Metadata service where metadata was returned for all indices when no indices were found was fixed in https://github.com/apache/metron/pull/827.  This caused a regression in the Alerts UI because it depends on the REST layer to figure out which indices to include and passes an empty index list.  The Column Metadata service should behave like the search service and default to a list of indices when none are passed in.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)