You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ta...@apache.org on 2017/04/05 11:02:48 UTC
svn commit: r1790215 - in /poi/trunk/src:
java/org/apache/poi/util/CodePageUtil.java
scratchpad/src/org/apache/poi/hwpf/model/OldTextPiece.java
Author: tallison
Date: Wed Apr 5 11:02:48 2017
New Revision: 1790215
URL: http://svn.apache.org/viewvc?rev=1790215&view=rev
Log:
bug 50955 convert Set to Singleton per Javen's code review
Modified:
poi/trunk/src/java/org/apache/poi/util/CodePageUtil.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/OldTextPiece.java
Modified: poi/trunk/src/java/org/apache/poi/util/CodePageUtil.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/CodePageUtil.java?rev=1790215&r1=1790214&r2=1790215&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/CodePageUtil.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/CodePageUtil.java Wed Apr 5 11:02:48 2017
@@ -19,7 +19,7 @@ package org.apache.poi.util;
import java.io.UnsupportedEncodingException;
import java.nio.charset.Charset;
-import java.util.HashSet;
+import java.util.Collections;
import java.util.Set;
/**
@@ -31,13 +31,7 @@ import java.util.Set;
public class CodePageUtil
{
- public static final Set<Charset> DOUBLE_BYTE_CHARSETS
- = new HashSet<Charset>();
-
- static {
- DOUBLE_BYTE_CHARSETS.add(StringUtil.BIG5);
- //others?
- }
+ public static final Set<Charset> DOUBLE_BYTE_CHARSETS = Collections.singleton(StringUtil.BIG5);
/** <p>Codepage 037, a special case</p> */
public static final int CP_037 = 37;
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/OldTextPiece.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/OldTextPiece.java?rev=1790215&r1=1790214&r2=1790215&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/OldTextPiece.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/OldTextPiece.java Wed Apr 5 11:02:48 2017
@@ -102,14 +102,6 @@ public class OldTextPiece extends TextPi
return 42; // any arbitrary constant will do
}
-
- /**
- * Returns the character position we start at.
- */
- public int getCP() {
- return getStart();
- }
-
public String toString() {
return "OldTextPiece from " + getStart() + " to " + getEnd() + " ("
+ getPieceDescriptor() + ")";
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org