[jira] [Commented] (CASSANDRA-6623) Null in a cell caused by expired TTL does not work with IF clause (in CQL3)

["Aleksey Yeschenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892577#comment-13892577 ] 

Aleksey Yeschenko commented on CASSANDRA-6623:
----------------------------------------------

LGTM

Nits:
- I'd rather see {code}if (!(c != null && c.isLive(now) && c.value().equals(e.value()))){code} rewritten as {code}if (c == null || c.isMarkedForDelete(now) || !c.value().equals(e.value())){code} in ThriftCASConditions (as it is more or less in ColumnsConditions, apparently)
- hasLiveColumns() in ColumnsCondition is dead code
- ByteBufferUtil in ModificationStatement; ColumnNameBuilder, NamesQueryFilter, and SliceQueryFilter in SP are now unused imports

> Null in a cell caused by expired TTL does not work with IF clause (in CQL3)
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-6623
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6623
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: One cluster with two nodes on a Linux and a Windows system. cqlsh 4.1.0 | Cassandra 2.0.4 | CQL spec 3.1.1 | Thrift protocol 19.39.0. CQL3 Column Family
>            Reporter: Csaba Seres
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 2.0.6
>
>         Attachments: 6623.txt
>
>
> IF onecell=null clause does not work if the onecell has got its null value from an expired TTL. If onecell is updated with null value (UPDATE) then IF onecell=null works fine.
> This bug is not present when you create a table with COMPACT STORAGE directive.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)