You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/02 08:19:22 UTC
[GitHub] [iceberg] openinx opened a new pull request #1162: Flink: Abstract the BaseParquetReaders so that GenericParquetReaders and FlinkParquetReaders could share the max part of the codes.
openinx opened a new pull request #1162:
URL: https://github.com/apache/iceberg/pull/1162
@rdblue this patch should address your concern about `public` interface/method issues, it also address the issue that `FlinkParquetReader` & `FlinkParquetWriter` have the duplicated `buildReader` & `buildWriter` codes.
Please take a look, Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1162: Flink: Abstract the BaseParquetReaders so that GenericParquetReaders and FlinkParquetReaders could share the max part of the codes.
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1162:
URL: https://github.com/apache/iceberg/pull/1162#issuecomment-653189327
Looks good to me. Thanks for the refactor, @openinx!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1162: Flink: Abstract the BaseParquetReaders so that GenericParquetReaders and FlinkParquetReaders could share the max part of the codes.
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1162:
URL: https://github.com/apache/iceberg/pull/1162
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org