You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "acehinnnqru (via GitHub)" <gi...@apache.org> on 2023/09/14 15:04:38 UTC

[GitHub] [incubator-opendal] acehinnnqru commented on a diff in pull request #3070: feat(services/cos): Rewrite the method signatures using OpWrite

acehinnnqru commented on code in PR #3070:
URL: https://github.com/apache/incubator-opendal/pull/3070#discussion_r1326100196


##########
core/src/services/cos/backend.rs:
##########
@@ -299,9 +299,12 @@ impl Accessor for CosBackend {
     }
 
     async fn create_dir(&self, path: &str, _: OpCreateDir) -> Result<RpCreateDir> {
-        let mut req =
-            self.core
-                .cos_put_object_request(path, Some(0), None, None, None, AsyncBody::Empty)?;
+        let mut req = self.core.cos_put_object_request(
+            path,
+            Some(0),
+            &Default::default(),

Review Comment:
   Yeah, That's what I am thinking...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org