You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/16 13:30:33 UTC
[GitHub] [skywalking] codecov-io commented on issue #4251: Issue about load
balance of gRPC
codecov-io commented on issue #4251: Issue about load balance of gRPC
URL: https://github.com/apache/skywalking/pull/4251#issuecomment-575151729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4251?src=pr&el=h1) Report
> Merging [#4251](https://codecov.io/gh/apache/skywalking/pull/4251?src=pr&el=desc) into [6.x](https://codecov.io/gh/apache/skywalking/commit/ffbe9f59ebd34beda55f0cba60d7e7c284461bb6?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/skywalking/pull/4251?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 6.x #4251 +/- ##
=========================================
- Coverage 27.3% 27.24% -0.06%
=========================================
Files 1140 1140
Lines 25027 25028 +1
Branches 3619 3619
=========================================
- Hits 6833 6819 -14
- Misses 17588 17608 +20
+ Partials 606 601 -5
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4251?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4251/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4251/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4251/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (-13.49%)` | :arrow_down: |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4251/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `82.02% <0%> (-2.25%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4251/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <0%> (-0.91%)` | :arrow_down: |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/4251/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `75.75% <0%> (+3.03%)` | :arrow_up: |
| [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4251/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `67.94% <0%> (+3.84%)` | :arrow_up: |
| [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4251/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `40.42% <0%> (+4.25%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4251?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4251?src=pr&el=footer). Last update [ffbe9f5...3ca9fc0](https://codecov.io/gh/apache/skywalking/pull/4251?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services