[jira] [Comment Edited] (OAK-6578) Enhance the IndexStoreStrategy to return list of matching values and paths

["Robert Munteanu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149565#comment-16149565 ] 

Robert Munteanu edited comment on OAK-6578 at 8/31/17 8:39 PM:
---------------------------------------------------------------

I've attached [^OAK-6578.patch] which implements the needed changes.

I've made added a new {{Iterable<IndexEntry> queryEntries}} method. It works much like the {{Iterable<String} query}} method, only that it returns both the matched property value and the path of the matching entry.

I've made it optional and only implemented it in the {{UniqueEntryStoreStrategy}} since:

- the implementation in the {{ContentMirrorStoreStrategy}} would complicate the {{PathIterator}} quite a bit to support this scenario efficiently
- we only need it in the {{UniqueEntryStoreStrategy}}

[~tmueller], [~chetanm] - would appreciate a quick review. I'm confident it does not break anything since the new methods will only be used by the code added in OAK-6506.


was (Author: rombert):
I've attached a [^OAK-6578] patch which implements the needed changes.

I've made added a new {{Iterable<IndexEntry> queryEntries}} method. It works much like the {{Iterable<String} query}} method, only that it returns both the matched property value and the path of the matching entry.

I've made it optional and only implemented it in the {{UniqueEntryStoreStrategy}} since:

- the implementation in the {{ContentMirrorStoreStrategy}} would complicate the {{PathIterator}} quite a bit to support this scenario efficiently
- we only need it in the {{UniqueEntryStoreStrategy}}

[~tmueller], [~chetanm] - would appreciate a quick review. I'm confident it does not break anything since the new methods will only be used by the code added in OAK-6506.

> Enhance the IndexStoreStrategy to return list of matching values and paths
> --------------------------------------------------------------------------
>
>                 Key: OAK-6578
>                 URL: https://issues.apache.org/jira/browse/OAK-6578
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: indexing
>            Reporter: Robert Munteanu
>            Assignee: Robert Munteanu
>             Fix For: 1.8, 1.7.7
>
>         Attachments: OAK-6578.patch
>
>
> For OAK-6506 I would need to extract from each index a list of all property values and paths. The property values would be used to check for duplicates, while the paths will be used for reporting.
> As the IndexStoreStrategy interface and its implementations do not support such access, we need to provide it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)