You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/17 06:15:32 UTC
[GitHub] [commons-beanutils] arturobernalg opened a new pull request #54: Minor Improvement
arturobernalg opened a new pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54
* Add Final
* change While loop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] garydgregory commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752102549
I think we need to get the build passing on Java 15 first to make it simpler to assess build results for PRs and master itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752197230
personally i would leave this PR. its not that big.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752193188
Nice work build is passing on both your PR's now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752195675
Create 2 new PR's and drop this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] jochenw commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
jochenw commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752134153
Are you reading? Rather than reducing the number of affected files, you just increased it to 24.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752186491
Can you bump your Jacoco in pom.xml 0.8.6 so it fixes the build and retriggers please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] jochenw commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
jochenw commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752135708
Sorry, mismatched this PR with another one on commons-fileupload. However, my opinion remains: 24 affected files is way too much for "minor improvements".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] arturobernalg commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752195403
Any idea of how can I split the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752136067
Oh OK. Yeah maybe the title is poor for this ticket but the improvements I think are good ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] arturobernalg closed pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
arturobernalg closed pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] arturobernalg commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752193894
Thank you very mucho @melloware
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] arturobernalg commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752196710
> Create 2 new PR's and drop this one.
Yep, the thing is, how many file? I think we need to have patience and give an opportunity to this kind of PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752103522
@gary any hint at what is wrong? It seems its JDK15 and higher that are the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752135476
> Are you reading? Rather than reducing the number of affected files, you just increased it to 24.
@jochenw What do you mean? Reading what? I don't understand what you are saying.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752137878
@garydgregory I think the build is failing with "java.util.ServiceConfigurationError: Locale provider adapter "CLDR"cannot be instantiated."
Which according to Stack Overflow that Code Coverage is not supported in JDK13+ so that is what is failing. I am surprised this is not happening on other Commons projects as well?
https://stackoverflow.com/questions/64696565/eclipse-testing-with-coverage-throws-java-lang-instrument-illegalclassformatexc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] arturobernalg commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752191443
Rebase from master.
the change is basically add final to some var. It's complicated create a PR with only some change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-747449005
I am a big fan of this change and using the `final` keyword. Joshua Bloch would approve!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] garydgregory commented on pull request #54: Minor Improvement
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #54:
URL: https://github.com/apache/commons-beanutils/pull/54#issuecomment-752111925
> @gary any hint at what is wrong? It seems its JDK15 and higher that are the issue.
I only noticed the build failure, not its cause.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org