You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2012/04/22 09:03:30 UTC
[jira] [Created] (MAPREDUCE-4174) Clean up
hadoop-mapreduce-client-common
Harsh J created MAPREDUCE-4174:
----------------------------------
Summary: Clean up hadoop-mapreduce-client-common
Key: MAPREDUCE-4174
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4174
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Components: build
Affects Versions: trunk
Reporter: Harsh J
Assignee: Harsh J
Priority: Minor
Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4174) Clean up
hadoop-mapreduce-client-common
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4174:
-------------------------------
Attachment: 0002-MR-Client-Common-Cleanup.patch
Complete cleanup (but some proto-generated files carry some warnings which I can't do anything about - will probably get fixed auto in a protobuf update)
> Clean up hadoop-mapreduce-client-common
> ---------------------------------------
>
> Key: MAPREDUCE-4174
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4174
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0002-MR-Client-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4174) Clean up
hadoop-mapreduce-client-common
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259258#comment-13259258 ]
Harsh J commented on MAPREDUCE-4174:
------------------------------------
The {{org.apache.hadoop.yarn.server.TestContainerManagerSecurity}} failure is unrelated to these changes.
> Clean up hadoop-mapreduce-client-common
> ---------------------------------------
>
> Key: MAPREDUCE-4174
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4174
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0002-MR-Client-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4174) Clean up
hadoop-mapreduce-client-common
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4174:
-------------------------------
Status: Patch Available (was: Open)
> Clean up hadoop-mapreduce-client-common
> ---------------------------------------
>
> Key: MAPREDUCE-4174
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4174
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0002-MR-Client-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4174) Clean up
hadoop-mapreduce-client-common
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265587#comment-13265587 ]
Tsz Wo (Nicholas), SZE commented on MAPREDUCE-4174:
---------------------------------------------------
{code}
+@SuppressWarnings("deprecation")
@Private
@Unstable
public class MRApps extends Apps {
{code}
Please do not add @SuppressWarnings in the class header. It basically turns off the warning feature for the entire class. We should fix the warnings but not suppress them.
> Clean up hadoop-mapreduce-client-common
> ---------------------------------------
>
> Key: MAPREDUCE-4174
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4174
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0002-MR-Client-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4174) Clean up
hadoop-mapreduce-client-common
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265562#comment-13265562 ]
Tom White commented on MAPREDUCE-4174:
--------------------------------------
+1
> Clean up hadoop-mapreduce-client-common
> ---------------------------------------
>
> Key: MAPREDUCE-4174
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4174
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0002-MR-Client-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MAPREDUCE-4174) Clean up
hadoop-mapreduce-client-common
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J resolved MAPREDUCE-4174.
--------------------------------
Resolution: Won't Fix
Patches were too broad and have gone stale. Will address these forms of issue over separate, smaller and more divided JIRAs in future.
Closing out parent JIRA MAPREDUCE-4172, and hence closing out this.
> Clean up hadoop-mapreduce-client-common
> ---------------------------------------
>
> Key: MAPREDUCE-4174
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4174
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0002-MR-Client-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4174) Clean up
hadoop-mapreduce-client-common
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4174:
-------------------------------
Status: Open (was: Patch Available)
Thanks Tom and Nicholas. I'll be addressing Nicholas' comments soon (need to sit down over a weekend again and fix as many of those kinda warns as I can).
> Clean up hadoop-mapreduce-client-common
> ---------------------------------------
>
> Key: MAPREDUCE-4174
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4174
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0002-MR-Client-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4174) Clean up
hadoop-mapreduce-client-common
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259037#comment-13259037 ]
Hadoop QA commented on MAPREDUCE-4174:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523669/0002-MR-Client-Common-Cleanup.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.yarn.server.TestContainerManagerSecurity
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2272//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2272//console
This message is automatically generated.
> Clean up hadoop-mapreduce-client-common
> ---------------------------------------
>
> Key: MAPREDUCE-4174
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4174
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0002-MR-Client-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira