[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

[andrewor14 <gi...@git.apache.org>]

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4129#discussion_r28388427
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala ---
    @@ -41,8 +41,20 @@ private[spark] class SparkDeploySchedulerBackend(
     
       private val registrationBarrier = new Semaphore(0)
     
    -  private val maxCores = conf.getOption("spark.cores.max").map(_.toInt)
    -  private val totalExpectedCores = maxCores.getOrElse(0)
    +  val maxCores = conf.getOption("spark.cores.max").map(_.toInt)
    +  val coreNumPerTask = conf.getInt("spark.task.cpus", 1)
    --- End diff --
    
    to reduce duplicate code, you can get this from `scheduler.CPUS_PER_TASK`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org