You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/05 18:46:29 UTC

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #977: Implements TLS for unaligned stacks.

patacongo commented on a change in pull request #977:
URL: https://github.com/apache/incubator-nuttx/pull/977#discussion_r420329945



##########
File path: arch/arm/include/tls.h
##########
@@ -97,11 +82,15 @@ static inline uint32_t up_getsp(void)
  *
  ****************************************************************************/
 
+#ifdef CONFIG_TLS_ALIGNED
 static inline FAR struct tls_info_s *up_tls_info(void)
 {
   DEBUGASSERT(!up_interrupt_context());
   return TLS_INFO((uintptr_t)up_getsp());

Review comment:
       I don't think so.  arch/arm/include/tls.h and arch/sim/include/tls.h implement this in very different ways.  sim uses a builtin.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org