You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by "style95 (via GitHub)" <gi...@apache.org> on 2023/03/10 10:56:04 UTC

[GitHub] [openwhisk-runtime-nodejs] style95 commented on a diff in pull request #233: Add functionality to install modules during init

style95 commented on code in PR #233:
URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/233#discussion_r1132230912


##########
core/nodejsActionBase/runner.js:
##########
@@ -46,6 +46,17 @@ function initializeActionHandler(message) {
                     return Promise.reject('Zipped actions must contain either package.json or index.js at the root.');
                 }
 
+                // install npm modules during init if source code zip doesn´t containt them

Review Comment:
   This is nice!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org