[jira] [Commented] (OOZIE-651) Coordinator rerun fails due to NPE in some cases

["jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183010#comment-13183010 ] 

jiraposter@reviews.apache.org commented on OOZIE-651:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/
-----------------------------------------------------------

Review request for oozie, Mohammad Islam and Angelo K. Huang.


Summary
-------

https://issues.apache.org/jira/browse/OOZIE-651


This addresses bug OOZIE-651.
    https://issues.apache.org/jira/browse/OOZIE-651


Diffs
-----

  trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389 
  trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION 
  trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 

Diff: https://reviews.apache.org/r/3441/diff


Testing
-------

Tested against current test cases
Test cases for CoordUtils added
Ran the coordinator rerun example


Thanks,

Virag


                
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
>                 Key: OOZIE-651
>                 URL: https://issues.apache.org/jira/browse/OOZIE-651
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Virag Kothari
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
>                     Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira