You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/11/18 19:48:15 UTC

[GitHub] [orc] johnwheffner opened a new issue, #1318: Byte to integer conversions fail on platforms with unsigned char type

johnwheffner opened a new issue, #1318:
URL: https://github.com/apache/orc/issues/1318

   When building the C++ library on a platform where `char` is by default unsigned, byte-to-integer expansion is incorrect in `orc::expandBytesToIntegers` as well as in a few unit tests.
   
   This can be reproduced on any CPU architecture when building with gcc by compiling with `-funsigned-char`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on issue #1318: Byte to integer conversions fail on platforms with unsigned char type

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on issue #1318:
URL: https://github.com/apache/orc/issues/1318#issuecomment-1329933526

   It's great. Thank you for the confirmation, @wgtmac .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on issue #1318: Byte to integer conversions fail on platforms with unsigned char type

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on issue #1318:
URL: https://github.com/apache/orc/issues/1318#issuecomment-1321415811

   Thank you, @johnwheffner and @wgtmac .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on issue #1318: Byte to integer conversions fail on platforms with unsigned char type

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on issue #1318:
URL: https://github.com/apache/orc/issues/1318#issuecomment-1321420944

   FYI. Apache ORC 1.8.1 is scheduled on December 3rd.
   
   cc @williamhyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] wgtmac commented on issue #1318: Byte to integer conversions fail on platforms with unsigned char type

Posted by GitBox <gi...@apache.org>.

wgtmac commented on issue #1318:
URL: https://github.com/apache/orc/issues/1318#issuecomment-1321329554

   @johnwheffner Thanks for reporting. We will fix it and let you know then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] wgtmac closed issue #1318: Byte to integer conversions fail on platforms with unsigned char type

Posted by GitBox <gi...@apache.org>.

wgtmac closed issue #1318: Byte to integer conversions fail on platforms with unsigned char type
URL: https://github.com/apache/orc/issues/1318


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] wgtmac commented on issue #1318: Byte to integer conversions fail on platforms with unsigned char type

Posted by GitBox <gi...@apache.org>.

wgtmac commented on issue #1318:
URL: https://github.com/apache/orc/issues/1318#issuecomment-1329955212

   @johnwheffner FYI, this issue has been fixed in the main branch. Please let me know if there is any remaining issue. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] wgtmac commented on issue #1318: Byte to integer conversions fail on platforms with unsigned char type

Posted by GitBox <gi...@apache.org>.

wgtmac commented on issue #1318:
URL: https://github.com/apache/orc/issues/1318#issuecomment-1328183678

   > Thank you, @johnwheffner and @wgtmac . For now, I set the milestone 1.9.0, but we can backport it to [Milestone 1.8.1](https://github.com/apache/orc/milestone/13).
   
   I can confirm that this issue only exists in the main branch, therefore we don't need backport the fix to branch-1.8.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org