You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by cakofony <gi...@git.apache.org> on 2018/06/07 12:51:35 UTC
[GitHub] logging-log4j2 pull request #177: Log4j 1.2 api tests do not leak MDC values...
GitHub user cakofony opened a pull request:
https://github.com/apache/logging-log4j2/pull/177
Log4j 1.2 api tests do not leak MDC values.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cakofony/logging-log4j2 log4j12_test_flake
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/177.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #177
----
commit a2a9f9f12533de2094265d558c96cbe81fac621e
Author: Carter Kozak <ck...@...>
Date: 2018-06-07T12:49:36Z
Log4j 1.2 api tests do not leak MDC values.
----
---
[GitHub] logging-log4j2 issue #177: Log4j 1.2 api tests do not leak MDC values.
Posted by cakofony <gi...@git.apache.org>.
Github user cakofony commented on the issue:
https://github.com/apache/logging-log4j2/pull/177
They pass about four of every five runs on my machine, but flake in the same way as the travis build every now and then.
I can reproduce consistently by executing `mvn clean && mvn test -pl log4j-mongodb2` in a loop 10 times.
---
[GitHub] logging-log4j2 issue #177: Log4j 1.2 api tests do not leak MDC values.
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/177
I do not think this patch should include ignoring Mongo tests.
---
[GitHub] logging-log4j2 issue #177: Log4j 1.2 api tests do not leak MDC values.
Posted by cakofony <gi...@git.apache.org>.
Github user cakofony commented on the issue:
https://github.com/apache/logging-log4j2/pull/177
> I do not think this patch should include ignoring Mongo tests.
Agreed, I've only merged the first commit. I'm curious of your thoughts on the mongo tests, I'd like to disable them until we can fix the flake rate, but I'm not sure when I'll have time to dig into the root cause.
---
[GitHub] logging-log4j2 issue #177: Log4j 1.2 api tests do not leak MDC values.
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/177
I would not '@Ignore' the mongo tests. You could use a JUnit Assume that skips the tests if an sys prop is set or something like that.
Note that the Jenkins builds are fine for now:
- 2.x https://builds.apache.org/view/L/view/Logging/job/Log4j%202%202.x/
- 3.x https://builds.apache.org/view/L/view/Logging/job/Log4j%202%203.x/
The tests pass on my machine but I understand that it can be a pain if they do not on your set up.
---
[GitHub] logging-log4j2 pull request #177: Log4j 1.2 api tests do not leak MDC values...
Posted by cakofony <gi...@git.apache.org>.
Github user cakofony closed the pull request at:
https://github.com/apache/logging-log4j2/pull/177
---