You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/01/06 11:36:11 UTC

[GitHub] [incubator-echarts] yufeng04 opened a new pull request #11985: fix bug #11801 Throw error when the action 'showTip' dispatched in radar chart

yufeng04 opened a new pull request #11985: fix bug #11801 Throw error when the action 'showTip' dispatched in radar chart
URL: https://github.com/apache/incubator-echarts/pull/11985
 
 
   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   Add a function to get tooltip position by referring to [map](https://github.com/apache/incubator-echarts/blob/master/src/chart/map/MapSeries.js#L159).
   
   
   ### Fixed issues
   Fixed issues #11801 
   
   <!--
   - #xxxx: ...
   -->
   
   
   ## Details
   
   ### Before: What was the problem?
   In radar chart, [the coordSys.dataToPoint](https://github.com/apache/incubator-echarts/blob/master/src/component/axisPointer/findPointFromSeries.js#L51) pass a parameter when the action 'showTip' dispatched, but the [dataToPoint](https://github.com/apache/incubator-echarts/blob/master/src/coord/radar/Radar.js#L87) needs two parameters.
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ### After: How is it fixed in this PR?
   Add a function to get tooltip position by referring to [map](https://github.com/apache/incubator-echarts/blob/master/src/chart/map/MapSeries.js#L159).
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] pissang merged pull request #11985: fix bug #11801 Throw error when the action 'showTip' dispatched in radar chart

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #11985: fix bug #11801 Throw error when the action 'showTip' dispatched in radar chart
URL: https://github.com/apache/incubator-echarts/pull/11985
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org