You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/16 09:33:15 UTC

[GitHub] [airflow] ashb commented on a change in pull request #11055: Fix fail to convert Pendulum to MySQL datetime

ashb commented on a change in pull request #11055:
URL: https://github.com/apache/airflow/pull/11055#discussion_r524026398



##########
File path: airflow/models/dagrun.py
##########
@@ -128,7 +128,8 @@ def refresh_from_db(self, session: Session = None):
         """
         DR = DagRun
 
-        exec_date = func.cast(self.execution_date, DateTime)
+        from airflow.utils.timezone import make_naive
+        exec_date = func.cast(make_naive(self.execution_date), DateTime)

Review comment:
       I am very skeptical that this is actually the right fix. https://github.com/apache/airflow/blob/master/airflow/utils/sqlalchemy.py#L41-L75 should already handle this case for MySQL, without messing up timezones for other databases.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org