[GitHub] [spark] Ngone51 commented on a change in pull request #28864: [SPARK-32004][ALL] Drop references to slave

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #28864:
URL: https://github.com/apache/spark/pull/28864#discussion_r442880517



##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -226,9 +226,9 @@ private[spark] class BlockManager(
   private val maxFailuresBeforeLocationRefresh =
     conf.get(config.BLOCK_FAILURES_BEFORE_LOCATION_REFRESH)
 
-  private val slaveEndpoint = rpcEnv.setupEndpoint(
+  private val replicaEndpoint = rpcEnv.setupEndpoint(

Review comment:
       This only a common BlockManager at executor side. Why it has to be specific to 'replica'?  Besides, replication also is disabled by default.  Therefore, it also doesn't make sense to me to change the name form 'BlockManagerSlaveEndpoint' to 'BlockManagerReplicaEndpoint' if we're searching a synonyms for 'Slave'.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org