You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@marvin.apache.org by we...@apache.org on 2020/10/09 14:27:42 UTC
[incubator-marvin] 03/05: Remove Jupyter Lab security flag
This is an automated email from the ASF dual-hosted git repository.
weichen pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/incubator-marvin.git
commit 29fe0b76ef48c2bb959a0040f74021cf07acdd07
Author: cardosolucas <ca...@gmail.com>
AuthorDate: Wed Sep 23 14:44:44 2020 -0300
Remove Jupyter Lab security flag
---
python-daemon/marvin_python_daemon/daemon_base/command_server.py | 3 +--
python-daemon/marvin_python_daemon/management/notebook.py | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/python-daemon/marvin_python_daemon/daemon_base/command_server.py b/python-daemon/marvin_python_daemon/daemon_base/command_server.py
index ebe4202..f304afe 100644
--- a/python-daemon/marvin_python_daemon/daemon_base/command_server.py
+++ b/python-daemon/marvin_python_daemon/daemon_base/command_server.py
@@ -53,9 +53,8 @@ def call_notebook(config, parameters):
def call_lab(config, parameters):
- security = strtobool(parameters['enable_security'])
- lab(config, bool(security), parameters['port'])
+ lab(config, parameters['port'])
def call_test(config, parameters):
diff --git a/python-daemon/marvin_python_daemon/management/notebook.py b/python-daemon/marvin_python_daemon/management/notebook.py
index 473a6a6..d2ed1ab 100644
--- a/python-daemon/marvin_python_daemon/management/notebook.py
+++ b/python-daemon/marvin_python_daemon/management/notebook.py
@@ -46,7 +46,7 @@ def notebook(config, port):
logger.info("Notebook call returned {0}".format(str(return_code)))
-def lab(config, enable_security, port):
+def lab(config, port):
notebookdir = os.path.join(config['base_path'], 'notebooks')
command = [
"SPARK_CONF_DIR={0} YARN_CONF_DIR={0}".format(
@@ -58,7 +58,6 @@ def lab(config, enable_security, port):
'--no-browser'
]
- command.append("--NotebookApp.token=") if enable_security else None
command.append("--allow-root")
return_code = os.system(' '.join(command))