You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Diana Arroyo <da...@us.ibm.com> on 2015/12/10 02:10:47 UTC
Re: Review Request 41090: CMake: Added FindCurl.cmake script to
locate curl library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41090/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 1:10 a.m.)
Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
Changes
-------
Addresses latest review comments.
Summary (updated)
-----------------
CMake: Added FindCurl.cmake script to locate curl library.
Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843
Repository: mesos
Description (updated)
-------
See summary.
Diffs (updated)
-----
src/slave/cmake/FindCurl.cmake PRE-CREATION
Diff: https://reviews.apache.org/r/41090/diff/
Testing
-------
Tested on Ubuntu and OSX.
Thanks,
Diana Arroyo
Re: Review Request 41090: CMake: Added FindCurl.cmake script to
locate curl library.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41090/#review109657
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Clemmer
On Dec. 10, 2015, 1:10 a.m., Diana Arroyo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41090/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 1:10 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/cmake/FindCurl.cmake PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41090/diff/
>
>
> Testing
> -------
>
> Tested on Ubuntu and OSX.
>
>
> Thanks,
>
> Diana Arroyo
>
>
Re: Review Request 41090: CMake: Added FindCurl.cmake script to
locate curl library.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41090/#review109675
-----------------------------------------------------------
Ship it!
used cURL in the comments / messages.
src/slave/cmake/FindCurl.cmake (line 23)
<https://reviews.apache.org/r/41090/#comment169271>
This should be 3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake
src/slave/cmake/FindCurl.cmake (line 26)
<https://reviews.apache.org/r/41090/#comment169269>
Comments end with a period.
src/slave/cmake/FindCurl.cmake (line 39)
<https://reviews.apache.org/r/41090/#comment169273>
let's wrap this at 80
src/slave/cmake/FindCurl.cmake (line 56)
<https://reviews.apache.org/r/41090/#comment169272>
cut
src/slave/cmake/FindCurl.cmake (line 81)
<https://reviews.apache.org/r/41090/#comment169274>
Let's wrap this at 80
- Joris Van Remoortere
On Dec. 10, 2015, 1:10 a.m., Diana Arroyo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41090/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 1:10 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/cmake/FindCurl.cmake PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41090/diff/
>
>
> Testing
> -------
>
> Tested on Ubuntu and OSX.
>
>
> Thanks,
>
> Diana Arroyo
>
>