You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/09 16:48:47 UTC

[GitHub] [arrow-datafusion] jychen7 opened a new pull request, #2187: Release 7.1.0

jychen7 opened a new pull request, #2187:
URL: https://github.com/apache/arrow-datafusion/pull/2187

   # Which issue does this PR close?
   
   minor release for 7.1.0
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   
   # Notes
   
   changelog is not updated yet, Github returns following throttle, will try again tonight
   
   > 403 - You have exceeded a secondary rate limit. Please wait a few minutes before you try again. // See: https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] jychen7 commented on pull request #2187: Prepare for 7.x release: Update version to 7.1.0, add ChangeLog

Posted by GitBox <gi...@apache.org>.
jychen7 commented on PR #2187:
URL: https://github.com/apache/arrow-datafusion/pull/2187#issuecomment-1094408572

   @alamb yes, I think it is good to go with 7.1.0. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] jychen7 commented on a diff in pull request #2187: Prepare for 7.x release: Update version to 7.1.0, add ChangeLog

Posted by GitBox <gi...@apache.org>.
jychen7 commented on code in PR #2187:
URL: https://github.com/apache/arrow-datafusion/pull/2187#discussion_r846792602


##########
datafusion-cli/Cargo.toml:
##########
@@ -31,7 +31,7 @@ rust-version = "1.58"
 clap = { version = "3", features = ["derive", "cargo"] }
 rustyline = "9.0"
 tokio = { version = "1.0", features = ["macros", "rt", "rt-multi-thread", "sync", "parking_lot"] }
-datafusion = { path = "../datafusion", version = "7.0.0" }
+datafusion = { path = "../datafusion", version = "7.1.0" }
 arrow = { version = "9.0.0" }
 ballista = { path = "../ballista/rust/client", version = "0.6.0" }
 env_logger = "0.9"

Review Comment:
   yes, some editor may remove trailing newlines. Either is fine with me too.
   
   this file didn't have newline at the end, so I just let it be
   https://github.com/apache/arrow-datafusion/blob/maint-7.x/datafusion-cli/Cargo.toml



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] jychen7 commented on pull request #2187: Release 7.1.0

Posted by GitBox <gi...@apache.org>.
jychen7 commented on PR #2187:
URL: https://github.com/apache/arrow-datafusion/pull/2187#issuecomment-1094155800

   @alamb do we think we still want to fix clippy for `maint-*` branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #2187: Release 7.1.0

Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #2187:
URL: https://github.com/apache/arrow-datafusion/pull/2187#discussion_r846758019


##########
datafusion-cli/Cargo.toml:
##########
@@ -31,7 +31,7 @@ rust-version = "1.58"
 clap = { version = "3", features = ["derive", "cargo"] }
 rustyline = "9.0"
 tokio = { version = "1.0", features = ["macros", "rt", "rt-multi-thread", "sync", "parking_lot"] }
-datafusion = { path = "../datafusion", version = "7.0.0" }
+datafusion = { path = "../datafusion", version = "7.1.0" }
 arrow = { version = "9.0.0" }
 ballista = { path = "../ballista/rust/client", version = "0.6.0" }
 env_logger = "0.9"

Review Comment:
   To unify the style, I think we can add a new line?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on pull request #2187: Prepare for 7.x release: Update version to 7.1.0, add ChangeLog

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2187:
URL: https://github.com/apache/arrow-datafusion/pull/2187#issuecomment-1094411056

   Cool -- thanks -- I will prepare a release for a vote - likely tomorrow 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2187: Prepare for 7.x release: Update version to 7.1.0, add ChangeLog

Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2187:
URL: https://github.com/apache/arrow-datafusion/pull/2187#discussion_r846758609


##########
datafusion/CHANGELOG.md:
##########
@@ -19,6 +19,14 @@
 
 # Changelog
 
+## [7.1.0](https://github.com/apache/arrow-datafusion/tree/7.1.0) (2022-04-10)
+
+[Full Changelog](https://github.com/apache/arrow-datafusion/compare/7.0.0...7.1.0)
+
+**Fixed bugs:**
+
+- By default, use only 1000 rows to infer the schema [\#2159](https://github.com/apache/arrow-datafusion/pull/2159)

Review Comment:
   👍 



##########
dev/release/update_change_log-all.sh:
##########
@@ -21,10 +21,11 @@
 set -e
 
 # Usage:

Review Comment:
   ```suggestion
   # Usage:
   # CHANGELOG_GITHUB_TOKEN=<TOKEN> ./update_change_log-all.sh <branch> <release_tag> <base_tag>
   # Example:
   ```



##########
datafusion-cli/Cargo.toml:
##########
@@ -31,7 +31,7 @@ rust-version = "1.58"
 clap = { version = "3", features = ["derive", "cargo"] }
 rustyline = "9.0"
 tokio = { version = "1.0", features = ["macros", "rt", "rt-multi-thread", "sync", "parking_lot"] }
-datafusion = { path = "../datafusion", version = "7.0.0" }
+datafusion = { path = "../datafusion", version = "7.1.0" }
 arrow = { version = "9.0.0" }
 ballista = { path = "../ballista/rust/client", version = "0.6.0" }
 env_logger = "0.9"

Review Comment:
   Either is fine with me -- I think some editors are configured to remove trailing newlines by default so perhaps that is what happened here?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on pull request #2187: Release 7.1.0

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2187:
URL: https://github.com/apache/arrow-datafusion/pull/2187#issuecomment-1094241632

   > 
   @alamb do we think we still want to fix clippy for maint-* branch?
   
    I think it would be helpful. I can get a PR up for it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on pull request #2187: Release 7.1.0

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2187:
URL: https://github.com/apache/arrow-datafusion/pull/2187#issuecomment-1094243332

   Here is a PR to fix clippy in 7.x branch: https://github.com/apache/arrow-datafusion/pull/2191


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on pull request #2187: Prepare for 7.x release: Update version to 7.1.0, add ChangeLog

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2187:
URL: https://github.com/apache/arrow-datafusion/pull/2187#issuecomment-1094408084

   Thanks @jychen7  -- shall I start the process to create 7.1.0 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb merged pull request #2187: Prepare for 7.x release: Update version to 7.1.0, add ChangeLog

Posted by GitBox <gi...@apache.org>.
alamb merged PR #2187:
URL: https://github.com/apache/arrow-datafusion/pull/2187


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org