You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/10/25 07:21:08 UTC
[jira] Created: (MPCLEAN-4) clean doesn't clean velocity.log.1
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPCLEAN-4
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPCLEAN-4
Summary: clean doesn't clean velocity.log.1
Type: Bug
Status: Unassigned
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-clean-plugin
Assignee:
Reporter: Shinobu Kawai
Created: Mon, 25 Oct 2004 1:20 AM
Updated: Mon, 25 Oct 2004 1:20 AM
Environment: Any time Velocity spits over 100KB of log
Description:
Currently, clean:clean only cleans velocity.log, and not velocity.log.1.
By default, Velocity uses the RollingFileAppender with maxBackupIndex=1 and maximumFileSize=100000. Which means, if the log file exceeds 100000 bytes, the log file will be rolled to velocity.log.1 and a new log file will start. If the clean plugin is going to clean the original log, it should also clean the rolled log.
(Or, I guess it could be put in the xdoc plugin.)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPCLEAN-4) clean doesn't clean velocity.log.1
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: David Eric Pugh
Created: Mon, 25 Oct 2004 5:18 AM
Body:
Brett does have a valid point. And his point is why I want to supply a generic maven.clean.includes patternset, versus a hardcoded velocity.log.1 file.
I agree, the fix you supplied should be in the xdoc plugin, it's specific to the logic of the xdoc plugin.
As an alternative, b/c we know that artifacts are created randomly, a pattern would be a solution.
I currenlty have tons of:
<postGoal name="clean">
<logic to delete tomcat logs and other werid stuff/>
</postGoal>
That could be replaced by the maven.clean.includes patternset.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPCLEAN-4?page=comments#action_25759
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPCLEAN-4
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPCLEAN-4
Summary: clean doesn't clean velocity.log.1
Type: Bug
Status: Open
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-clean-plugin
Assignee: David Eric Pugh
Reporter: Shinobu Kawai
Created: Mon, 25 Oct 2004 1:20 AM
Updated: Mon, 25 Oct 2004 5:18 AM
Environment: Any time Velocity spits over 100KB of log
Description:
Currently, clean:clean only cleans velocity.log, and not velocity.log.1.
By default, Velocity uses the RollingFileAppender with maxBackupIndex=1 and maximumFileSize=100000. Which means, if the log file exceeds 100000 bytes, the log file will be rolled to velocity.log.1 and a new log file will start. If the clean plugin is going to clean the original log, it should also clean the rolled log.
(Or, I guess it could be put in the xdoc plugin.)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPCLEAN-4) clean doesn't clean velocity.log.1
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: David Eric Pugh
Created: Mon, 25 Oct 2004 4:51 AM
Body:
While your patch would work for velocity.log.1, it won't work for velocity.log.2 or name your extra artifact.
If you are interested, look at how other plugins implement includes and excludes patterns. PMD and JCoverage would be examples.
What you really want are a list of maven.clean.include patterns that you would specify:
maven.clean.include=*.log.*,myOtherLog.log
Eric
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPCLEAN-4?page=comments#action_25757
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPCLEAN-4
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPCLEAN-4
Summary: clean doesn't clean velocity.log.1
Type: Bug
Status: Unassigned
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-clean-plugin
Assignee:
Reporter: Shinobu Kawai
Created: Mon, 25 Oct 2004 1:20 AM
Updated: Mon, 25 Oct 2004 4:51 AM
Environment: Any time Velocity spits over 100KB of log
Description:
Currently, clean:clean only cleans velocity.log, and not velocity.log.1.
By default, Velocity uses the RollingFileAppender with maxBackupIndex=1 and maximumFileSize=100000. Which means, if the log file exceeds 100000 bytes, the log file will be rolled to velocity.log.1 and a new log file will start. If the clean plugin is going to clean the original log, it should also clean the rolled log.
(Or, I guess it could be put in the xdoc plugin.)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPXDOC-124) clean doesn't clean velocity.log.1
Posted by ji...@codehaus.org.
Message:
The following issue has been closed.
Resolver: David Eric Pugh
Date: Tue, 26 Oct 2004 5:05 AM
Fixed with a postgoal on clean:clean.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPXDOC-124
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPXDOC-124
Summary: clean doesn't clean velocity.log.1
Type: Bug
Status: Closed
Priority: Minor
Resolution: FIXED
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-xdoc-plugin
Fix Fors:
1.9
Assignee: David Eric Pugh
Reporter: Shinobu Kawai
Created: Mon, 25 Oct 2004 1:20 AM
Updated: Tue, 26 Oct 2004 5:05 AM
Environment: Any time Velocity spits over 100KB of log
Description:
Currently, clean:clean only cleans velocity.log, and not velocity.log.1.
By default, Velocity uses the RollingFileAppender with maxBackupIndex=1 and maximumFileSize=100000. Which means, if the log file exceeds 100000 bytes, the log file will be rolled to velocity.log.1 and a new log file will start. If the clean plugin is going to clean the original log, it should also clean the rolled log.
(Or, I guess it could be put in the xdoc plugin.)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPCLEAN-4) clean doesn't clean velocity.log.1
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Shinobu Kawai (mailto:shinobu@ieee.org)
Date: Mon, 25 Oct 2004 1:22 AM
Comment:
A patch to let clean:clean clean the rolled log file as well
Changes:
Attachment changed to clean.patch
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPCLEAN-4?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPCLEAN-4
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPCLEAN-4
Summary: clean doesn't clean velocity.log.1
Type: Bug
Status: Unassigned
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-clean-plugin
Assignee:
Reporter: Shinobu Kawai
Created: Mon, 25 Oct 2004 1:20 AM
Updated: Mon, 25 Oct 2004 1:22 AM
Environment: Any time Velocity spits over 100KB of log
Description:
Currently, clean:clean only cleans velocity.log, and not velocity.log.1.
By default, Velocity uses the RollingFileAppender with maxBackupIndex=1 and maximumFileSize=100000. Which means, if the log file exceeds 100000 bytes, the log file will be rolled to velocity.log.1 and a new log file will start. If the clean plugin is going to clean the original log, it should also clean the rolled log.
(Or, I guess it could be put in the xdoc plugin.)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPCLEAN-4) clean doesn't clean velocity.log.1
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Shinobu Kawai (mailto:shinobu.kawai@gmail.com)
Date: Mon, 25 Oct 2004 9:33 PM
Comment:
Okay, here's the patch to move the Velocity log cleaning to the xdoc plugin. As for the maven.clean.include extension, I think a new issue should be filed.
Changes:
Attachment changed to xdoc-clean.patch
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPCLEAN-4?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPCLEAN-4
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPCLEAN-4
Summary: clean doesn't clean velocity.log.1
Type: Bug
Status: Open
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-clean-plugin
Assignee: David Eric Pugh
Reporter: Shinobu Kawai
Created: Mon, 25 Oct 2004 1:20 AM
Updated: Mon, 25 Oct 2004 9:33 PM
Environment: Any time Velocity spits over 100KB of log
Description:
Currently, clean:clean only cleans velocity.log, and not velocity.log.1.
By default, Velocity uses the RollingFileAppender with maxBackupIndex=1 and maximumFileSize=100000. Which means, if the log file exceeds 100000 bytes, the log file will be rolled to velocity.log.1 and a new log file will start. If the clean plugin is going to clean the original log, it should also clean the rolled log.
(Or, I guess it could be put in the xdoc plugin.)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPCLEAN-4) clean doesn't clean velocity.log.1
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Shinobu Kawai
Created: Mon, 25 Oct 2004 5:12 AM
Body:
Don't worry, Velocity will only roll one file, so the patch is sufficient in Velocity's case. B)
I read Brett's comment in http://jira.codehaus.org/browse/MPCLEAN-2, and it made me think, "If they want the torque plugin to clean up its mess, why is the clean plugin so generous as to clean up Velocity's mess?". If Velocity is so special, I guessed the patch could be Velocity-specific. (The velocity.log was there from the date of birth.)
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPCLEAN-4?page=comments#action_25758
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPCLEAN-4
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPCLEAN-4
Summary: clean doesn't clean velocity.log.1
Type: Bug
Status: Open
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-clean-plugin
Assignee: David Eric Pugh
Reporter: Shinobu Kawai
Created: Mon, 25 Oct 2004 1:20 AM
Updated: Mon, 25 Oct 2004 5:12 AM
Environment: Any time Velocity spits over 100KB of log
Description:
Currently, clean:clean only cleans velocity.log, and not velocity.log.1.
By default, Velocity uses the RollingFileAppender with maxBackupIndex=1 and maximumFileSize=100000. Which means, if the log file exceeds 100000 bytes, the log file will be rolled to velocity.log.1 and a new log file will start. If the clean plugin is going to clean the original log, it should also clean the rolled log.
(Or, I guess it could be put in the xdoc plugin.)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org