You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/06/16 15:25:20 UTC
[GitHub] [activemq-artemis] gemmellr opened a new pull request #3186: ARTEMIS-2109: fix ErrorProne for JDK8, move to profile
gemmellr opened a new pull request #3186:
URL: https://github.com/apache/activemq-artemis/pull/3186
Fixes the updated configuration for ErrorProne so it can actually run on JDK8.
Also moves it to a specific profile for optional use on JDK8, as the 2.4.0+ javac plugin approach requires forking the compiler on JDK8, which is slow and adds a couple of minutes to the build from all the modules. On JDK8 Error Prone is activated on request. On JDK11+ it is still enabled by default.
Updates the CI job config as well to still enable ErrorProne for JDK8 (i.e. on all JDKs being used).
Follows the changes in #3179 (and #3183).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3186: ARTEMIS-2109: fix ErrorProne for JDK8, move to profile
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3186:
URL: https://github.com/apache/activemq-artemis/pull/3186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit merged pull request #3186: ARTEMIS-2109: fix ErrorProne for JDK8, move to profile
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #3186:
URL: https://github.com/apache/activemq-artemis/pull/3186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on a change in pull request #3186: ARTEMIS-2109: fix ErrorProne for JDK8, move to profile
Posted by GitBox <gi...@apache.org>.
gemmellr commented on a change in pull request #3186:
URL: https://github.com/apache/activemq-artemis/pull/3186#discussion_r441009693
##########
File path: .travis.yml
##########
@@ -24,7 +24,7 @@ before_install:
# By setting anything to org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED we are disabling libaio loading on the testsuite
script:
- set -e
-- mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Pfast-tests -Pextra-tests -Ptests-CI -B install -q
+- mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Djdk8-errorprone -Pfast-tests -Pextra-tests -Ptests-CI -B install -q
Review comment:
No, as that would enable the JDK8 arguments on 11+ and break them. The profile can be activated explicitly with -P or by JDK8+property. Using the property as here stops it from actually adding the JDK-8 specific bits on JDK11+ when run there (since the job script is shared across all 3) which would break.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr removed a comment on pull request #3186: ARTEMIS-2109: fix ErrorProne for JDK8, move to profile
Posted by GitBox <gi...@apache.org>.
gemmellr removed a comment on pull request #3186:
URL: https://github.com/apache/activemq-artemis/pull/3186#issuecomment-644894205
No, as that would enable the JDK8 arguments on 11+ and break them. The profile can be activated explicitly with -P or by JDK8+property. Using the property as here stops it from actually adding the JDK-8 specific bits on JDK11+ when run there (since the job script is shared across all 3) which would break.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3186: ARTEMIS-2109: fix ErrorProne for JDK8, move to profile
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3186:
URL: https://github.com/apache/activemq-artemis/pull/3186#discussion_r441006643
##########
File path: .travis.yml
##########
@@ -24,7 +24,7 @@ before_install:
# By setting anything to org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED we are disabling libaio loading on the testsuite
script:
- set -e
-- mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Pfast-tests -Pextra-tests -Ptests-CI -B install -q
+- mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Djdk8-errorprone -Pfast-tests -Pextra-tests -Ptests-CI -B install -q
Review comment:
didn't you mean -Pjdk8-errorprone?
-P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3186: ARTEMIS-2109: fix ErrorProne for JDK8, move to profile
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3186:
URL: https://github.com/apache/activemq-artemis/pull/3186#discussion_r441079307
##########
File path: .travis.yml
##########
@@ -24,7 +24,7 @@ before_install:
# By setting anything to org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED we are disabling libaio loading on the testsuite
script:
- set -e
-- mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Pfast-tests -Pextra-tests -Ptests-CI -B install -q
+- mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Djdk8-errorprone -Pfast-tests -Pextra-tests -Ptests-CI -B install -q
Review comment:
@gemmellr thanks for the clarification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3186: ARTEMIS-2109: fix ErrorProne for JDK8, move to profile
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3186:
URL: https://github.com/apache/activemq-artemis/pull/3186#issuecomment-644894205
No, as that would enable the JDK8 arguments on 11+ and break them. The profile can be activated explicitly with -P or by JDK8+property. Using the property as here stops it from actually adding the JDK-8 specific bits on JDK11+ when run there (since the job script is shared across all 3) which would break.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org